reversed order of items in indicator applet and missing icons

Bug #653995 reported by Pavol Klačanský
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
liferea (Ubuntu)
Fix Released
Low
Luke Yelavich

Bug Description

Binary package hint: liferea

Hallo, one patch fixes order of item, another add icon support

Tags: patch

Related branches

Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :
tags: added: patch
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

No one would like apply patch? Why?

Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

thanks for ingoring :/, I am wondering, why you don't fix it (you don't have to use my patch, just fix it), but I really don't know, how can I change it

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report and work there, where is your patch? The merge request seems buggy. Sorry for the reply delay as well but there is lot of bug and not so many people working on triaging those

Changed in liferea (Ubuntu):
importance: Undecided → Low
status: New → Incomplete
status: Incomplete → New
Revision history for this message
Sebastien Bacher (seb128) wrote :

Ken, Karl could you review the patch there?

Changed in liferea (Ubuntu):
assignee: nobody → Karl Lattimer (karl-qdh)
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

thanks for reply

Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

and how could I help with fixing and triaging bugs? I wanna help comunity

Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :
Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

And patch

Revision history for this message
Luke Yelavich (themuso) wrote :

Thank you very much for your contribution to Ubuntu. I am currently in the process of reviewing the branch you have proposed. If there are no issues, I will merge the branch, mark the merge proposal accordingly, and upload your change to Ubuntu.

Thanks again for your work.

Changed in liferea (Ubuntu):
assignee: Karl Lattimer (karl-qdh) → Luke Yelavich (themuso)
status: New → In Progress
Revision history for this message
Luke Yelavich (themuso) wrote :

Thanks very much for your work. Your branch has been merged, and I have uploaded a new revision of the package into Ubuntu natty. I took the extra step and integrated your indicator_icons.patch into the main libindicate.patch, since your fix is to the indicator code.

Thanks once again for your work.

Changed in liferea (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package liferea - 1.6.4-1ubuntu2

---------------
liferea (1.6.4-1ubuntu2) natty; urgency=low

  * debian/patches/libindicate.patch: Fixed reversed order and missing
    favicons in indicator applet, thanks to Pavol Klačanský for the patch.
    (LP: #653995)
 -- Luke Yelavich <email address hidden> Tue, 30 Nov 2010 17:36:05 +1100

Changed in liferea (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Luke Yelavich (themuso) wrote :

Sorry I totally missed the patch you attached to this bug with the changelog entry included. If you could include the changelog entry when you next create a branch to be merged, that would be much appreciated.

Thanks again.

Revision history for this message
Pavol Klačanský (pavolzetor-deactivatedaccount) wrote :

ok, thanks, did you apply only my patch, because, I cannot get it working in indicator-messages now :/
and I cannot compile it http://bugs.debian.org/604608

When I made it, it worked perfectly :/

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.