logrotate-charm

Code review comment for ~txiao/charm-logrotated:handle_unset

  1. Git
  2. lp:~txiao/charm-logrotated
  3. handle_unset
  4. Merge into master
Revision history for this message
Tianqi Xiao (txiao) wrote :

Thanks @eric-chen @kamalb @raychan96 @rgildein for the reviews. The MP has been updated to include the suggested changes. For the resetting the cron value, since it's out of the current scope, I opened LP#2016659 to track it[1]

[1]: https://bugs.launchpad.net/charm-logrotated/+bug/2016659

« Back to merge proposal