~txiao/charm-logrotated:handle_unset

Branch merges

Propose for merging

Merged into charm-logrotated:master at revision a137eb7f109dca499ec59fe7bcc7c47ee93d4596

🤖 prod-jenkaas-bootstack (community): Approve (continuous-integration) on 2023-04-17

Robert Gildein: Approve on 2023-04-17

Eric Chen: Needs Fixing on 2023-04-17

Kamal Bhaskar: Approve on 2023-04-17

Diff: 130 lines (+43/-10)

3 files modified

src/lib/lib_cron.py (+20/-8)
src/reactive/logrotate.py (+14/-2)
src/tests/unit/test_logrotate.py (+9/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

8746e27... by Tianqi Xiao on 2023-04-17

Handle "unset" value of update-cron-daily-schedule and fix workload status logic

Previously, validating "unset" value would result in silent error because:
1. the con_mapping in CronHelper.validate_cron_conf() doesn't contain "unset" key
which leads to an attemption of concatenating str with NoneType
2. wrongly checking index 0 of a str instead of list for self.cron_daily_schedule
in CronHelper.install_cronjob()
3. wrong logic for setting status in install and config_changed hook, which means
the workload status always end up as active even when exceptions are raised
4. didn't set workload status to blocked when executing cronjob.

This commit fixes the above mentioned issues and added related unit tests.
Additionally, more logs are added to provide extra information.

8d04a63... by Gabriel Cocenza on 2023-04-05

Pin libjuju to make it compatible with controllers <3.0

Reviewed-on: https://code.launchpad.net/~gabrielcocenza/charm-logrotated/+git/charm-logrotated/+merge/440354
Reviewed-by: Martin Kalcok <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Ramesh Sattaru <email address hidden>

8397fc5... by Gabriel Cocenza on 2023-04-04

Pin libjuju to make it compatible with controllers <3.0

8ac7c44... by Kamal Bhaskar on 2023-01-20

Reschedule cron.daily jobs to non-default/random timings. LP #1998895. Updated cron update logic using regex.

Reviewed-on: https://code.launchpad.net/~llama-charmers/charm-logrotated/+git/charm-logrotated/+merge/435334
Reviewed-by: Eric Chen <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Erhan Sunar <email address hidden>
Reviewed-by: Tianqi Xiao <email address hidden>

e0aada5... by Sudeep Bhandari on 2023-01-20

- Dropped Xenial support
- Fixed build issue in bionic

Fixes bug: #2003232

Reviewed-on: https://code.launchpad.net/~sudeephb/charm-logrotated/+git/charm-logrotated/+merge/436116
Reviewed-by: Ramesh Sattaru <email address hidden>
Reviewed-by: 🤖 prod-jenkaas-bootstack <email address hidden>
Reviewed-by: Martin Kalcok <email address hidden>

26a61a1... by Sudeep Bhandari on 2023-01-20

Drop Xenial support, fix build issue in bionic

cc2ae8d... by Kamal Bhaskar on 2023-01-20

updated unittests as per suggestions

4f13db4... by Kamal Bhaskar on 2023-01-19

added unit tests for methods validate_cron_conf and update_cron_daily_schedule

ac97a34... by Kamal Bhaskar on 2023-01-17

refactored validate_cron_conf to reduce complexity

df57874... by Kamal Bhaskar on 2023-01-13

added functional tests for feature update-cron-daily-schedule