Code review comment for lp:~tribaal/livecd-rootfs/fix-ova-manifest

Revision history for this message
Robert C Jennings (rcj) wrote :

+1 on the code changes.

The commit messages should refer to the bug (i.e. (LP: #1627931) and when you commit you can add the '--fixes lp:#####' flag to get the bug in the commit metadata as well (see http://bazaar.launchpad.net/~ubuntu-core-dev/livecd-rootfs/trunk/revision/1446.1.1).

Not a fan of the comment on r1456 as it lacks context without reading r1455, but a merge commit will take care of that.

review: Needs Fixing

« Back to merge proposal