Merge lp:~tribaal/livecd-rootfs/fix-ova-manifest into lp:livecd-rootfs
Proposed by
Chris Glass
Status: | Merged |
---|---|
Merged at revision: | 1455 |
Proposed branch: | lp:~tribaal/livecd-rootfs/fix-ova-manifest |
Merge into: | lp:livecd-rootfs |
Diff against target: |
25 lines (+2/-2) 2 files modified
live-build/ubuntu-cpc/hooks/041-vmdk-ova-image.binary (+1/-1) live-build/ubuntu-cpc/hooks/042-vagrant.binary (+1/-1) |
To merge this branch: | bzr merge lp:~tribaal/livecd-rootfs/fix-ova-manifest |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Robert C Jennings (community) | Approve | ||
Dan Watkins (community) | Approve | ||
Philip Roche (community) | Approve | ||
Ubuntu Core Development Team | Pending | ||
Review via email: mp+314682@code.launchpad.net |
Description of the change
This branch fixes the OVA generation.
When creating the manifest we passed the .ova extension twice, resulting in an invalide filename.
To post a comment you must log in.
+1 on the code changes.
The commit messages should refer to the bug (i.e. (LP: #1627931) and when you commit you can add the '--fixes lp:#####' flag to get the bug in the commit metadata as well (see http:// bazaar. launchpad. net/~ubuntu- core-dev/ livecd- rootfs/ trunk/revision/ 1446.1. 1).
Not a fan of the comment on r1456 as it lacks context without reading r1455, but a merge commit will take care of that.