Merge lp:~trb143/openlp/bugs into lp:openlp
Proposed by
Tim Bentley
Status: | Merged | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Merged at revision: | 1387 | ||||||||||||
Proposed branch: | lp:~trb143/openlp/bugs | ||||||||||||
Merge into: | lp:openlp | ||||||||||||
Diff against target: |
103 lines (+37/-1) 1 file modified
openlp/core/ui/maindisplay.py (+37/-1) |
||||||||||||
To merge this branch: | bzr merge lp:~trb143/openlp/bugs | ||||||||||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Andreas Preikschat (community) | Approve | ||
Jon Tibble (community) | Approve | ||
Raoul Snyman | Approve | ||
Review via email: mp+53213@code.launchpad.net |
This proposal supersedes a proposal from 2011-03-14.
Description of the change
Blank video at the end when it is finished.
Additional comments.
Hook for later development work.
To post a comment you must log in.
What is "200" in terms of "setTickInterval"? Can you maybe just put a comment in that explains what the unit is for that number? i.e.
# Need the timer to trigger m.start_ time != 0:
self.mediaObje ct.setTickInter val(200)
if self.serviceIte
# Set the tick interval to 200ms
Note: I see afterwards that you explain it in the docstring for the slot method, but that doesn't really have a bearing on the actual interval.