Code review comment for lp:~trb143/openlp/bugs

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

What is "200" in terms of "setTickInterval"? Can you maybe just put a comment in that explains what the unit is for that number? i.e.

    # Need the timer to trigger
    if self.serviceItem.start_time != 0:
        # Set the tick interval to 200ms
        self.mediaObject.setTickInterval(200)

Note: I see afterwards that you explain it in the docstring for the slot method, but that doesn't really have a bearing on the actual interval.

review: Needs Information

« Back to merge proposal