Merge lp:~trb143/openlp/bugfixes into lp:openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trb143/openlp/bugfixes
Merge into: lp:openlp
Diff against target: None lines
To merge this branch: bzr merge lp:~trb143/openlp/bugfixes
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+12027@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Fix presentation messaging : issue by using an array

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

50 + if desktop==None:
51 + return

Change that to "if desktop is None:" next time please.

review: Approve
lp:~trb143/openlp/bugfixes updated
548. By Tim Bentley

presentation fixes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/core/lib/rendermanager.py'
--- openlp/core/lib/rendermanager.py 2009-09-08 19:58:05 +0000
+++ openlp/core/lib/rendermanager.py 2009-09-16 19:00:17 +0000
@@ -63,7 +63,7 @@
63 else:63 else:
64 self.current_display = screen_number64 self.current_display = screen_number
65 self.renderer = Renderer()65 self.renderer = Renderer()
66 #self.calculate_default(self.screen_list[self.current_display][u'size'])66 self.calculate_default(self.screen_list[self.current_display][u'size'])
67 self.theme = u''67 self.theme = u''
68 self.service_theme = u''68 self.service_theme = u''
69 self.global_style = u''69 self.global_style = u''
7070
=== modified file 'openlp/core/ui/slidecontroller.py'
--- openlp/core/ui/slidecontroller.py 2009-09-15 20:06:39 +0000
+++ openlp/core/ui/slidecontroller.py 2009-09-18 06:07:10 +0000
@@ -254,7 +254,7 @@
254 self.enableToolBar(item)254 self.enableToolBar(item)
255 if item.service_item_type == ServiceType.Command:255 if item.service_item_type == ServiceType.Command:
256 Receiver().send_message(u'%s_start'%item.name.lower(), \256 Receiver().send_message(u'%s_start'%item.name.lower(), \
257 u'%s:%s:%s' % (item.shortname, item.service_item_path, item.service_frames[0][u'title']))257 [item.shortname, item.service_item_path, item.service_frames[0][u'title']])
258 else:258 else:
259 self.displayServiceManagerItems(item, 0)259 self.displayServiceManagerItems(item, 0)
260260
@@ -272,7 +272,7 @@
272 self.enableToolBar(item)272 self.enableToolBar(item)
273 if item.service_item_type == ServiceType.Command:273 if item.service_item_type == ServiceType.Command:
274 Receiver().send_message(u'%s_start'%item.name.lower(), \274 Receiver().send_message(u'%s_start'%item.name.lower(), \
275 u'%s:%s:%s' % (item.shortname, item.service_item_path, item.service_frames[0][u'title']))275 [item.shortname, item.service_item_path, item.service_frames[0][u'title']])
276 else:276 else:
277 self.displayServiceManagerItems(item, slideno)277 self.displayServiceManagerItems(item, slideno)
278278
279279
=== modified file 'openlp/plugins/presentations/lib/impresscontroller.py'
--- openlp/plugins/presentations/lib/impresscontroller.py 2009-09-17 07:28:47 +0000
+++ openlp/plugins/presentations/lib/impresscontroller.py 2009-09-18 06:07:10 +0000
@@ -89,12 +89,12 @@
89 log.debug(u'LoadPresentation')89 log.debug(u'LoadPresentation')
90 if os.name == u'nt':90 if os.name == u'nt':
91 desktop = self.getCOMDesktop()91 desktop = self.getCOMDesktop()
92 url = u'file:///' + presentation.replace(u'\\', u'/').replace(u':', u'|').replace(u' ', u'%20') 92 url = u'file:///' + presentation.replace(u'\\', u'/').replace(u':', u'|').replace(u' ', u'%20')
93 else:93 else:
94 desktop = self.getUNODesktop()94 desktop = self.getUNODesktop()
95 url = uno.systemPathToFileUrl(presentation)95 url = uno.systemPathToFileUrl(presentation)
96 if(desktop==None):96 if desktop==None:
97 return 97 return
98 try:98 try:
99 properties = []99 properties = []
100 properties = tuple(properties)100 properties = tuple(properties)
101101
=== modified file 'openlp/plugins/presentations/lib/messagelistener.py'
--- openlp/plugins/presentations/lib/messagelistener.py 2009-09-07 05:13:39 +0000
+++ openlp/plugins/presentations/lib/messagelistener.py 2009-09-18 06:07:10 +0000
@@ -83,6 +83,5 @@
83 ``message``83 ``message``
84 Message containing Presentaion handler name and file to be presented.84 Message containing Presentaion handler name and file to be presented.
85 """85 """
86 bits = message.split(u':')86 file = os.path.join(message[1], message[2])
87 file = os.path.join(bits[1], bits[2])87 return message[0], file
88 return bits[0], file