Merge lp:~trb143/openlp/audit into lp:openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trb143/openlp/audit
Merge into: lp:openlp
Diff against target: 56 lines
1 file modified
openlp/plugins/bibles/lib/mediaitem.py (+9/-9)
To merge this branch: bzr merge lp:~trb143/openlp/audit
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+13121@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Changes to hide plugins broke Bible rendering.
This fixes it.

Revision history for this message
Raoul Snyman (raoul-snyman) :
review: Approve
lp:~trb143/openlp/audit updated
621. By Tim Bentley

Bible New features and Clean up

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/bibles/lib/mediaitem.py'
--- openlp/plugins/bibles/lib/mediaitem.py 2009-10-08 05:02:39 +0000
+++ openlp/plugins/bibles/lib/mediaitem.py 2009-10-09 12:55:21 +0000
@@ -345,20 +345,20 @@
345 verse = unicode(self.search_results[0].verse)345 verse = unicode(self.search_results[0].verse)
346 text = self.search_results[0].text346 text = self.search_results[0].text
347 #Paragraph style force new line per verse347 #Paragraph style force new line per verse
348 if self.parent.bibles_tab.layout_style == 1:348 if self.parent.settings_tab.layout_style == 1:
349 text = text + u'\n\n'349 text = text + u'\n\n'
350 if self.parent.bibles_tab.display_style == 1:350 if self.parent.settings_tab.display_style == 1:
351 loc = self.formatVerse(old_chapter, chapter, verse, u'(u', u')')351 loc = self.formatVerse(old_chapter, chapter, verse, u'(u', u')')
352 elif self.parent.bibles_tab.display_style == 2:352 elif self.parent.settings_tab.display_style == 2:
353 loc = self.formatVerse(old_chapter, chapter, verse, u'{', u'}')353 loc = self.formatVerse(old_chapter, chapter, verse, u'{', u'}')
354 elif self.parent.bibles_tab.display_style == 3:354 elif self.parent.settings_tab.display_style == 3:
355 loc = self.formatVerse(old_chapter, chapter, verse, u'[', u']')355 loc = self.formatVerse(old_chapter, chapter, verse, u'[', u']')
356 else:356 else:
357 loc = self.formatVerse(old_chapter, chapter, verse, u'', u'')357 loc = self.formatVerse(old_chapter, chapter, verse, u'', u'')
358 old_chapter = chapter358 old_chapter = chapter
359 bible_text = bible_text + u' '+ loc + u' '+ text359 bible_text = bible_text + u' '+ loc + u' '+ text
360 #if we are verse per slide then create slide360 #if we are verse per slide then create slide
361 if self.parent.bibles_tab.layout_style == 0:361 if self.parent.settings_tab.layout_style == 0:
362 raw_slides.append(bible_text)362 raw_slides.append(bible_text)
363 bible_text = u''363 bible_text = u''
364 service_item.title = book + u' ' + loc364 service_item.title = book + u' ' + loc
@@ -368,12 +368,12 @@
368 raw_footer.index(footer)368 raw_footer.index(footer)
369 except:369 except:
370 raw_footer.append(footer)370 raw_footer.append(footer)
371 if len(self.parent.bibles_tab.bible_theme) == 0:371 if len(self.parent.settings_tab.bible_theme) == 0:
372 service_item.theme = None372 service_item.theme = None
373 else:373 else:
374 service_item.theme = self.parent.bibles_tab.bible_theme374 service_item.theme = self.parent.settings_tab.bible_theme
375 #if we are verse per slide we have already been added375 #if we are verse per slide we have already been added
376 if self.parent.bibles_tab.layout_style != 0:376 if self.parent.settings_tab.layout_style != 0:
377 raw_slides.append(bible_text)377 raw_slides.append(bible_text)
378 for slide in raw_slides:378 for slide in raw_slides:
379 service_item.add_from_text(slide[:30], slide)379 service_item.add_from_text(slide[:30], slide)
@@ -384,7 +384,7 @@
384 loc = opening384 loc = opening
385 if old_chapter != chapter:385 if old_chapter != chapter:
386 loc += chapter + u':'386 loc += chapter + u':'
387 elif not self.parent.bibles_tab.show_new_chapters:387 elif not self.parent.settings_tab.show_new_chapters:
388 loc += chapter + u':'388 loc += chapter + u':'
389 loc += verse389 loc += verse
390 loc += closing390 loc += closing
391391
=== modified file 'openlp/plugins/songs/songsplugin.py'