Merge lp:~trb143/openlp/audit into lp:openlp

Proposed by Tim Bentley
Status: Merged
Merged at revision: not available
Proposed branch: lp:~trb143/openlp/audit
Merge into: lp:openlp
Diff against target: 76 lines
5 files modified
openlp/plugins/audit/auditplugin.py (+3/-11)
openlp/plugins/audit/lib/classes.py (+1/-0)
openlp/plugins/audit/lib/meta.py (+1/-0)
openlp/plugins/audit/lib/tables.py (+2/-1)
openlp/plugins/songs/lib/mediaitem.py (+1/-1)
To merge this branch: bzr merge lp:~trb143/openlp/audit
Reviewer Review Type Date Requested Status
Raoul Snyman Approve
Review via email: mp+12326@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Bentley (trb143) wrote :

Fix up audit database with copyright
Fix runtime errors from last merge.

This merge requires you to delete your audit database!

Revision history for this message
Raoul Snyman (raoul-snyman) wrote :

What's with the extra line in classes.py and meta.py?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'openlp/plugins/audit/auditplugin.py'
--- openlp/plugins/audit/auditplugin.py 2009-09-23 17:36:22 +0000
+++ openlp/plugins/audit/auditplugin.py 2009-09-24 04:55:20 +0000
@@ -116,7 +116,8 @@
116 audititem.auditdate = datetime.today()116 audititem.auditdate = datetime.today()
117 audititem.audittime = datetime.now().time()117 audititem.audittime = datetime.now().time()
118 audititem.title = auditData[0]118 audititem.title = auditData[0]
119 audititem.ccl_id = auditData[2]119 audititem.copyright = auditData[2]
120 audititem.ccl_number = auditData[3]
120 audititem.authors = u''121 audititem.authors = u''
121 for author in auditData[1]:122 for author in auditData[1]:
122 audititem.authors += author + u' '123 audititem.authors += author + u' '
@@ -129,14 +130,5 @@
129 """130 """
130 self.auditActive = str_to_bool(131 self.auditActive = str_to_bool(
131 self.config.get_config(u'audit active', False))132 self.config.get_config(u'audit active', False))
132 if self.auditFileNameNew == u'':133# self.ToolsAuditItem.setChecked(self.auditActive)
133 self.auditActive = False
134 self.ToolsAuditItem.setChecked(self.auditActive)
135 self.ToolsAuditItem.setEnabled(False)
136 return
137 self.ToolsAuditItem.setEnabled(True)134 self.ToolsAuditItem.setEnabled(True)
138 if self.auditFileNameNew != self.auditFileName:
139 if self.auditFile is not None:
140 self.auditFile.close()
141 self.auditFile = open(self.auditFileNameNew, u'a')
142
143135
=== modified file 'openlp/plugins/audit/lib/classes.py'
--- openlp/plugins/audit/lib/classes.py 2009-09-23 15:51:03 +0000
+++ openlp/plugins/audit/lib/classes.py 2009-09-24 04:55:20 +0000
@@ -22,6 +22,7 @@
22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #
23###############################################################################23###############################################################################
2424
25
25class BaseModel(object):26class BaseModel(object):
26 """27 """
27 BaseModel provides a base object with a set of generic functions28 BaseModel provides a base object with a set of generic functions
2829
=== modified file 'openlp/plugins/audit/lib/meta.py'
--- openlp/plugins/audit/lib/meta.py 2009-09-22 19:37:36 +0000
+++ openlp/plugins/audit/lib/meta.py 2009-09-24 04:55:20 +0000
@@ -22,6 +22,7 @@
22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #22# Temple Place, Suite 330, Boston, MA 02111-1307 USA #
23###############################################################################23###############################################################################
2424
25
25from sqlalchemy import MetaData26from sqlalchemy import MetaData
26from sqlalchemy.orm import scoped_session, sessionmaker27from sqlalchemy.orm import scoped_session, sessionmaker
2728
2829
=== modified file 'openlp/plugins/audit/lib/tables.py'
--- openlp/plugins/audit/lib/tables.py 2009-09-23 16:33:30 +0000
+++ openlp/plugins/audit/lib/tables.py 2009-09-24 04:55:20 +0000
@@ -33,5 +33,6 @@
33 Column(u'audittime', types.Time, index=True, nullable=False),33 Column(u'audittime', types.Time, index=True, nullable=False),
34 Column(u'title', types.Unicode(255), nullable=False),34 Column(u'title', types.Unicode(255), nullable=False),
35 Column(u'authors', types.Unicode(255), nullable=False),35 Column(u'authors', types.Unicode(255), nullable=False),
36 Column(u'ccl_id', types.Unicode(65), nullable=False)36 Column(u'copyright', types.Unicode(255)),
37 Column(u'ccl_number', types.Unicode(65))
37)38)
3839
=== modified file 'openlp/plugins/songs/lib/mediaitem.py'
--- openlp/plugins/songs/lib/mediaitem.py 2009-09-21 17:56:36 +0000
+++ openlp/plugins/songs/lib/mediaitem.py 2009-09-24 04:55:20 +0000
@@ -308,5 +308,5 @@
308 raw_footer.append(unicode(308 raw_footer.append(unicode(
309 translate(u'SongMediaItem', u'CCL Licence: ') + ccl))309 translate(u'SongMediaItem', u'CCL Licence: ') + ccl))
310 service_item.raw_footer = raw_footer310 service_item.raw_footer = raw_footer
311 service_item.audit = [service_item.title, author_audit, ccl]311 service_item.audit = [song.title, author_audit, song.copyright, song.ccli_number]
312 return True312 return True