Merge lp:~tpeeters/ubuntu-ui-toolkit/more-visual-updates into lp:ubuntu-ui-toolkit/staging
- more-visual-updates
- Merge into staging
Status: | Merged |
---|---|
Approved by: | Tim Peeters |
Approved revision: | 1178 |
Merged at revision: | 1171 |
Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/more-visual-updates |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
370 lines (+69/-36) 16 files modified
examples/ubuntu-ui-toolkit-gallery/Buttons.qml (+1/-1) examples/ubuntu-ui-toolkit-gallery/Dialog.qml (+17/-10) modules/Ubuntu/Components/Colors/UbuntuColors.qml (+4/-4) modules/Ubuntu/Components/ListItems/Empty.qml (+17/-0) modules/Ubuntu/Components/Popups/Dialog.qml (+2/-2) modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml (+3/-1) modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml (+6/-5) modules/Ubuntu/Components/Themes/Ambiance/DialogForegroundStyle.qml (+1/-3) modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml (+2/-0) modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml (+2/-2) modules/Ubuntu/Components/Themes/Ambiance/Palette.qml (+1/-1) modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml (+3/-1) modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml (+4/-2) modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml (+4/-2) modules/Ubuntu/Components/Themes/SuruDark/Palette.qml (+1/-1) tests/autopilot/ubuntuuitoolkit/tests/gallery/test_buttons.py (+1/-1) |
To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/more-visual-updates |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Cris Dywan | Approve | ||
Review via email:
|
Commit message
Visual updates: colors, icon sizes, semi-transparent buttons
Description of the change
Visual updates for several components:
- White dialog
- Re-enable listitem highlight when pressed or selected
- Update UbuntuColors
- Update icon sizes in header
- Fix slider color
- Update button colors in gallery
- Make disabled buttons semi-transparent
- Update checkbox colors and animation speed
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Cris Dywan (kalikiana) : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Continuous integration, rev:1172
http://
Executed test runs:
UNSTABLE: http://
FAILURE: http://
FAILURE: http://
SUCCESS: http://
deb: http://
FAILURE: http://
UNSTABLE: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) wrote : | # |
FAILED: Autolanding.
More details in the following jenkins job:
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Cris Dywan (kalikiana) wrote : | # |
Damn I should've caught that one. Obviously right move.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Tim Peeters (tpeeters) wrote : | # |
re-happroving because of staging sync.
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
PS Jenkins bot (ps-jenkins) : | # |
Preview Diff
1 | === modified file 'examples/ubuntu-ui-toolkit-gallery/Buttons.qml' | |||
2 | --- examples/ubuntu-ui-toolkit-gallery/Buttons.qml 2014-06-20 15:15:11 +0000 | |||
3 | +++ examples/ubuntu-ui-toolkit-gallery/Buttons.qml 2014-07-30 19:29:37 +0000 | |||
4 | @@ -49,7 +49,7 @@ | |||
5 | 49 | Button { | 49 | Button { |
6 | 50 | objectName: "button_color" | 50 | objectName: "button_color" |
7 | 51 | text: i18n.tr("Call") | 51 | text: i18n.tr("Call") |
9 | 52 | color: UbuntuColors.warmGrey | 52 | color: UbuntuColors.green |
10 | 53 | } | 53 | } |
11 | 54 | } | 54 | } |
12 | 55 | 55 | ||
13 | 56 | 56 | ||
14 | === modified file 'examples/ubuntu-ui-toolkit-gallery/Dialog.qml' | |||
15 | --- examples/ubuntu-ui-toolkit-gallery/Dialog.qml 2014-04-23 09:39:11 +0000 | |||
16 | +++ examples/ubuntu-ui-toolkit-gallery/Dialog.qml 2014-07-30 19:29:37 +0000 | |||
17 | @@ -15,7 +15,7 @@ | |||
18 | 15 | */ | 15 | */ |
19 | 16 | 16 | ||
20 | 17 | import QtQuick 2.0 | 17 | import QtQuick 2.0 |
22 | 18 | import Ubuntu.Components 0.1 | 18 | import Ubuntu.Components 1.1 |
23 | 19 | import Ubuntu.Components.Popups 0.1 | 19 | import Ubuntu.Components.Popups 0.1 |
24 | 20 | 20 | ||
25 | 21 | Template { | 21 | Template { |
26 | @@ -41,16 +41,23 @@ | |||
27 | 41 | id: dialogue | 41 | id: dialogue |
28 | 42 | 42 | ||
29 | 43 | title: "Sample Dialog" | 43 | title: "Sample Dialog" |
31 | 44 | text: "Are you sure you want to delete this file?" | 44 | text: "Descriptive text goes here" |
32 | 45 | 45 | ||
41 | 46 | Button { | 46 | Row { |
42 | 47 | text: "Cancel" | 47 | id: row |
43 | 48 | gradient: UbuntuColors.greyGradient | 48 | width: parent.width |
44 | 49 | onClicked: PopupUtils.close(dialogue) | 49 | spacing: units.gu(1) |
45 | 50 | } | 50 | Button { |
46 | 51 | Button { | 51 | width: parent.width/2 |
47 | 52 | text: "Delete" | 52 | text: "Cancel" |
48 | 53 | onClicked: PopupUtils.close(dialogue) | 53 | onClicked: PopupUtils.close(dialogue) |
49 | 54 | } | ||
50 | 55 | Button { | ||
51 | 56 | width: parent.width/2 | ||
52 | 57 | text: "Confirm" | ||
53 | 58 | color: UbuntuColors.green | ||
54 | 59 | onClicked: PopupUtils.close(dialogue) | ||
55 | 60 | } | ||
56 | 54 | } | 61 | } |
57 | 55 | } | 62 | } |
58 | 56 | } | 63 | } |
59 | 57 | 64 | ||
60 | === modified file 'modules/Ubuntu/Components/Colors/UbuntuColors.qml' | |||
61 | --- modules/Ubuntu/Components/Colors/UbuntuColors.qml 2014-07-02 11:35:33 +0000 | |||
62 | +++ modules/Ubuntu/Components/Colors/UbuntuColors.qml 2014-07-30 19:29:37 +0000 | |||
63 | @@ -95,7 +95,7 @@ | |||
64 | 95 | secondary text. | 95 | secondary text. |
65 | 96 | \since Ubuntu.Components 1.1 | 96 | \since Ubuntu.Components 1.1 |
66 | 97 | */ | 97 | */ |
68 | 98 | readonly property color lightGrey: "#888888" | 98 | readonly property color lightGrey: "#929292" |
69 | 99 | 99 | ||
70 | 100 | /*! | 100 | /*! |
71 | 101 | Dark grey. Recommended for text and action icons. | 101 | Dark grey. Recommended for text and action icons. |
72 | @@ -108,19 +108,19 @@ | |||
73 | 108 | buttons, errors and alerts. | 108 | buttons, errors and alerts. |
74 | 109 | \since Ubuntu.Components 1.1 | 109 | \since Ubuntu.Components 1.1 |
75 | 110 | */ | 110 | */ |
77 | 111 | readonly property color red: "#fc4949" | 111 | readonly property color red: "#f32c36" |
78 | 112 | 112 | ||
79 | 113 | /*! | 113 | /*! |
80 | 114 | Green. Recommended for positive action buttons. | 114 | Green. Recommended for positive action buttons. |
81 | 115 | \since Ubuntu.Components 1.1 | 115 | \since Ubuntu.Components 1.1 |
82 | 116 | */ | 116 | */ |
84 | 117 | readonly property color green: "#3fb24f" | 117 | readonly property color green: "#00a132" |
85 | 118 | 118 | ||
86 | 119 | /*! | 119 | /*! |
87 | 120 | Blue. Recommended for text selection and text cursor. | 120 | Blue. Recommended for text selection and text cursor. |
88 | 121 | \since Ubuntu.Components 1.1 | 121 | \since Ubuntu.Components 1.1 |
89 | 122 | */ | 122 | */ |
91 | 123 | readonly property color blue: "#1ab6ef" | 123 | readonly property color blue: "#12a3d8" |
92 | 124 | 124 | ||
93 | 125 | /*! | 125 | /*! |
94 | 126 | Purple. Recommended for proper nouns in | 126 | Purple. Recommended for proper nouns in |
95 | 127 | 127 | ||
96 | === modified file 'modules/Ubuntu/Components/ListItems/Empty.qml' | |||
97 | --- modules/Ubuntu/Components/ListItems/Empty.qml 2014-07-15 13:05:55 +0000 | |||
98 | +++ modules/Ubuntu/Components/ListItems/Empty.qml 2014-07-30 19:29:37 +0000 | |||
99 | @@ -288,6 +288,23 @@ | |||
100 | 288 | } | 288 | } |
101 | 289 | } | 289 | } |
102 | 290 | 290 | ||
103 | 291 | Rectangle { | ||
104 | 292 | id: highlight | ||
105 | 293 | |||
106 | 294 | z: -1 | ||
107 | 295 | visible: !priv.removed && emptyListItem.swipingState === "" | ||
108 | 296 | ? emptyListItem.selected | ||
109 | 297 | || (emptyListItem.highlightWhenPressed && emptyListItem.pressed) | ||
110 | 298 | : false | ||
111 | 299 | anchors { | ||
112 | 300 | left: parent.left | ||
113 | 301 | right: parent.right | ||
114 | 302 | top: parent.top | ||
115 | 303 | } | ||
116 | 304 | height: emptyListItem.height - bottomDividerLine.height | ||
117 | 305 | color: Qt.rgba(0, 0, 0, 0.05) | ||
118 | 306 | } | ||
119 | 307 | |||
120 | 291 | ThinDivider { | 308 | ThinDivider { |
121 | 292 | id: bottomDividerLine | 309 | id: bottomDividerLine |
122 | 293 | anchors.bottom: parent.bottom | 310 | anchors.bottom: parent.bottom |
123 | 294 | 311 | ||
124 | === modified file 'modules/Ubuntu/Components/Popups/Dialog.qml' | |||
125 | --- modules/Ubuntu/Components/Popups/Dialog.qml 2014-04-23 08:50:20 +0000 | |||
126 | +++ modules/Ubuntu/Components/Popups/Dialog.qml 2014-07-30 19:29:37 +0000 | |||
127 | @@ -188,14 +188,14 @@ | |||
128 | 188 | horizontalAlignment: Text.AlignHCenter | 188 | horizontalAlignment: Text.AlignHCenter |
129 | 189 | text: dialog.title | 189 | text: dialog.title |
130 | 190 | fontSize: "large" | 190 | fontSize: "large" |
132 | 191 | color: Qt.rgba(1, 1, 1, 0.9) | 191 | color: UbuntuColors.darkGrey |
133 | 192 | } | 192 | } |
134 | 193 | 193 | ||
135 | 194 | Label { | 194 | Label { |
136 | 195 | horizontalAlignment: Text.AlignHCenter | 195 | horizontalAlignment: Text.AlignHCenter |
137 | 196 | text: dialog.text | 196 | text: dialog.text |
138 | 197 | fontSize: "medium" | 197 | fontSize: "medium" |
140 | 198 | color: Qt.rgba(1, 1, 1, 0.6) | 198 | color: UbuntuColors.darkGrey |
141 | 199 | wrapMode: Text.Wrap | 199 | wrapMode: Text.Wrap |
142 | 200 | } | 200 | } |
143 | 201 | 201 | ||
144 | 202 | 202 | ||
145 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml' | |||
146 | --- modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml 2014-07-09 10:56:01 +0000 | |||
147 | +++ modules/Ubuntu/Components/Themes/Ambiance/ButtonStyle.qml 2014-07-30 19:29:37 +0000 | |||
148 | @@ -25,7 +25,8 @@ | |||
149 | 25 | property var button: styledItem | 25 | property var button: styledItem |
150 | 26 | property real minimumWidth: units.gu(10) | 26 | property real minimumWidth: units.gu(10) |
151 | 27 | property real horizontalPadding: units.gu(1) | 27 | property real horizontalPadding: units.gu(1) |
153 | 28 | property color defaultColor: UbuntuColors.orange | 28 | // FIXME: Add this color to the palette |
154 | 29 | property color defaultColor: "#b2b2b2" | ||
155 | 29 | property font defaultFont: Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")}) | 30 | property font defaultFont: Qt.font({family: "Ubuntu", pixelSize: FontUtils.sizeToPixels("medium")}) |
156 | 30 | property Gradient defaultGradient | 31 | property Gradient defaultGradient |
157 | 31 | property real buttonFaceOffset: 0 | 32 | property real buttonFaceOffset: 0 |
158 | @@ -123,6 +124,7 @@ | |||
159 | 123 | image: backgroundSource | 124 | image: backgroundSource |
160 | 124 | 125 | ||
161 | 125 | color: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.topColor) : __colorHack(button.color))) | 126 | color: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.topColor) : __colorHack(button.color))) |
162 | 127 | opacity: styledItem.enabled ? 1.0 : 0.6 | ||
163 | 126 | gradientColor: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.bottomColor) : __colorHack(button.color))) | 128 | gradientColor: stroke ? "" : (backgroundSource ? "#00000000" : (isGradient ? __colorHack(gradientProxy.bottomColor) : __colorHack(button.color))) |
164 | 127 | } | 129 | } |
165 | 128 | 130 | ||
166 | 129 | 131 | ||
167 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml' | |||
168 | --- modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml 2014-07-21 11:44:25 +0000 | |||
169 | +++ modules/Ubuntu/Components/Themes/Ambiance/CheckBoxStyle.qml 2014-07-30 19:29:37 +0000 | |||
170 | @@ -65,7 +65,8 @@ | |||
171 | 65 | } | 65 | } |
172 | 66 | PropertyChanges { | 66 | PropertyChanges { |
173 | 67 | target: background | 67 | target: background |
175 | 68 | color: Theme.palette.normal.foreground | 68 | color: Qt.rgba(Theme.palette.normal.foreground.r, Theme.palette.normal.foreground.g, |
176 | 69 | Theme.palette.normal.foreground.b, 0.2) | ||
177 | 69 | } | 70 | } |
178 | 70 | } | 71 | } |
179 | 71 | ] | 72 | ] |
180 | @@ -76,7 +77,7 @@ | |||
181 | 76 | to: "unchecked" | 77 | to: "unchecked" |
182 | 77 | ColorAnimation { | 78 | ColorAnimation { |
183 | 78 | target: background | 79 | target: background |
185 | 79 | duration: UbuntuAnimation.BriskDuration | 80 | duration: UbuntuAnimation.FastDuration |
186 | 80 | easing: UbuntuAnimation.StandardEasingReverse | 81 | easing: UbuntuAnimation.StandardEasingReverse |
187 | 81 | } | 82 | } |
188 | 82 | SequentialAnimation { | 83 | SequentialAnimation { |
189 | @@ -88,7 +89,7 @@ | |||
190 | 88 | NumberAnimation { | 89 | NumberAnimation { |
191 | 89 | target: tick | 90 | target: tick |
192 | 90 | property: "anchors.verticalCenterOffset" | 91 | property: "anchors.verticalCenterOffset" |
194 | 91 | duration: UbuntuAnimation.BriskDuration | 92 | duration: UbuntuAnimation.FastDuration |
195 | 92 | easing: UbuntuAnimation.StandardEasingReverse | 93 | easing: UbuntuAnimation.StandardEasingReverse |
196 | 93 | } | 94 | } |
197 | 94 | PropertyAction { | 95 | PropertyAction { |
198 | @@ -103,7 +104,7 @@ | |||
199 | 103 | to: "checked" | 104 | to: "checked" |
200 | 104 | ColorAnimation { | 105 | ColorAnimation { |
201 | 105 | target: background | 106 | target: background |
203 | 106 | duration: UbuntuAnimation.BriskDuration | 107 | duration: UbuntuAnimation.FastDuration |
204 | 107 | easing: UbuntuAnimation.StandardEasing | 108 | easing: UbuntuAnimation.StandardEasing |
205 | 108 | } | 109 | } |
206 | 109 | SequentialAnimation { | 110 | SequentialAnimation { |
207 | @@ -115,7 +116,7 @@ | |||
208 | 115 | NumberAnimation { | 116 | NumberAnimation { |
209 | 116 | target: tick | 117 | target: tick |
210 | 117 | property: "anchors.verticalCenterOffset" | 118 | property: "anchors.verticalCenterOffset" |
212 | 118 | duration: UbuntuAnimation.BriskDuration | 119 | duration: UbuntuAnimation.FastDuration |
213 | 119 | easing: UbuntuAnimation.StandardEasing | 120 | easing: UbuntuAnimation.StandardEasing |
214 | 120 | } | 121 | } |
215 | 121 | PropertyAction { | 122 | PropertyAction { |
216 | 122 | 123 | ||
217 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/DialogForegroundStyle.qml' | |||
218 | --- modules/Ubuntu/Components/Themes/Ambiance/DialogForegroundStyle.qml 2014-04-23 08:50:20 +0000 | |||
219 | +++ modules/Ubuntu/Components/Themes/Ambiance/DialogForegroundStyle.qml 2014-07-30 19:29:37 +0000 | |||
220 | @@ -20,11 +20,9 @@ | |||
221 | 20 | Item { | 20 | Item { |
222 | 21 | id: dialogForegroundStyle | 21 | id: dialogForegroundStyle |
223 | 22 | 22 | ||
224 | 23 | visible: styledItem.dismissArea.width > units.gu(60) | ||
225 | 24 | |||
226 | 25 | UbuntuShape { | 23 | UbuntuShape { |
227 | 26 | id: background | 24 | id: background |
228 | 27 | anchors.fill: parent | 25 | anchors.fill: parent |
230 | 28 | color: Qt.rgba(0, 0, 0, 0.7) | 26 | color: "white" |
231 | 29 | } | 27 | } |
232 | 30 | } | 28 | } |
233 | 31 | 29 | ||
234 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml' | |||
235 | --- modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml 2014-04-23 08:50:20 +0000 | |||
236 | +++ modules/Ubuntu/Components/Themes/Ambiance/OptionSelectorStyle.qml 2014-07-30 19:29:37 +0000 | |||
237 | @@ -31,5 +31,7 @@ | |||
238 | 31 | width: styledItem.width | 31 | width: styledItem.width |
239 | 32 | height: styledItem.height | 32 | height: styledItem.height |
240 | 33 | radius: "medium" | 33 | radius: "medium" |
241 | 34 | |||
242 | 35 | color: Qt.rgba(0, 0, 0, 0.05) | ||
243 | 34 | } | 36 | } |
244 | 35 | } | 37 | } |
245 | 36 | 38 | ||
246 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml' | |||
247 | --- modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml 2014-07-29 12:16:53 +0000 | |||
248 | +++ modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml 2014-07-30 19:29:37 +0000 | |||
249 | @@ -20,10 +20,10 @@ | |||
250 | 20 | AbstractButton { | 20 | AbstractButton { |
251 | 21 | id: button | 21 | id: button |
252 | 22 | 22 | ||
254 | 23 | property real iconWidth: units.gu(2) | 23 | property real iconWidth: units.gu(2.5) |
255 | 24 | property real iconHeight: iconWidth | 24 | property real iconHeight: iconWidth |
256 | 25 | 25 | ||
258 | 26 | width: visible ? units.gu(4) : 0 | 26 | width: visible ? units.gu(5) : 0 |
259 | 27 | height: parent ? parent.height : undefined | 27 | height: parent ? parent.height : undefined |
260 | 28 | 28 | ||
261 | 29 | Image { | 29 | Image { |
262 | 30 | 30 | ||
263 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/Palette.qml' | |||
264 | --- modules/Ubuntu/Components/Themes/Ambiance/Palette.qml 2014-07-21 11:44:25 +0000 | |||
265 | +++ modules/Ubuntu/Components/Themes/Ambiance/Palette.qml 2014-07-30 19:29:37 +0000 | |||
266 | @@ -39,7 +39,7 @@ | |||
267 | 39 | background: "#B2E6E6E6" | 39 | background: "#B2E6E6E6" |
268 | 40 | backgroundText: UbuntuColors.darkGrey | 40 | backgroundText: UbuntuColors.darkGrey |
269 | 41 | selection: Qt.rgba(UbuntuColors.blue.r, UbuntuColors.blue.g, UbuntuColors.blue.b, 0.2) | 41 | selection: Qt.rgba(UbuntuColors.blue.r, UbuntuColors.blue.g, UbuntuColors.blue.b, 0.2) |
271 | 42 | foreground: UbuntuColors.blue | 42 | foreground: UbuntuColors.orange |
272 | 43 | foregroundText: UbuntuColors.darkGrey | 43 | foregroundText: UbuntuColors.darkGrey |
273 | 44 | field: "#FFFFFF" | 44 | field: "#FFFFFF" |
274 | 45 | fieldText: UbuntuColors.darkGrey | 45 | fieldText: UbuntuColors.darkGrey |
275 | 46 | 46 | ||
276 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml' | |||
277 | --- modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml 2014-07-18 07:19:36 +0000 | |||
278 | +++ modules/Ubuntu/Components/Themes/Ambiance/TextCursorStyle.qml 2014-07-30 19:29:37 +0000 | |||
279 | @@ -15,6 +15,7 @@ | |||
280 | 15 | */ | 15 | */ |
281 | 16 | 16 | ||
282 | 17 | import QtQuick 2.0 | 17 | import QtQuick 2.0 |
283 | 18 | import Ubuntu.Components 1.1 | ||
284 | 18 | 19 | ||
285 | 19 | // FIXME : move the API into Ubuntu.Components.Style | 20 | // FIXME : move the API into Ubuntu.Components.Style |
286 | 20 | Item { | 21 | Item { |
287 | @@ -48,7 +49,8 @@ | |||
288 | 48 | id: delegate | 49 | id: delegate |
289 | 49 | Rectangle { | 50 | Rectangle { |
290 | 50 | width: units.dp(2) | 51 | width: units.dp(2) |
292 | 51 | color: Theme.palette.selected.foreground | 52 | // FIXME: Extend the palette and use palette values here |
293 | 53 | color: UbuntuColors.blue | ||
294 | 52 | visible: blinkTimer.timerShowCursor | 54 | visible: blinkTimer.timerShowCursor |
295 | 53 | Timer { | 55 | Timer { |
296 | 54 | id: blinkTimer | 56 | id: blinkTimer |
297 | 55 | 57 | ||
298 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml' | |||
299 | --- modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml 2014-07-02 12:19:28 +0000 | |||
300 | +++ modules/Ubuntu/Components/Themes/Ambiance/TextSelectionEndCursorStyle.qml 2014-07-30 19:29:37 +0000 | |||
301 | @@ -14,7 +14,8 @@ | |||
302 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
303 | 15 | */ | 15 | */ |
304 | 16 | 16 | ||
306 | 17 | import QtQuick 2.0 | 17 | import QtQuick 2.2 |
307 | 18 | import Ubuntu.Components 1.1 | ||
308 | 18 | 19 | ||
309 | 19 | // FIXME : move the API into Ubuntu.Components.Style | 20 | // FIXME : move the API into Ubuntu.Components.Style |
310 | 20 | Item { | 21 | Item { |
311 | @@ -48,7 +49,8 @@ | |||
312 | 48 | id: delegate | 49 | id: delegate |
313 | 49 | Rectangle { | 50 | Rectangle { |
314 | 50 | width: units.dp(1) | 51 | width: units.dp(1) |
316 | 51 | color: Theme.palette.selected.foreground | 52 | // FIXME: Add a new color to the palette |
317 | 53 | color: UbuntuColors.blue | ||
318 | 52 | } | 54 | } |
319 | 53 | } | 55 | } |
320 | 54 | 56 | ||
321 | 55 | 57 | ||
322 | === modified file 'modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml' | |||
323 | --- modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml 2014-07-02 12:19:28 +0000 | |||
324 | +++ modules/Ubuntu/Components/Themes/Ambiance/TextSelectionStartCursorStyle.qml 2014-07-30 19:29:37 +0000 | |||
325 | @@ -14,7 +14,8 @@ | |||
326 | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. | 14 | * along with this program. If not, see <http://www.gnu.org/licenses/>. |
327 | 15 | */ | 15 | */ |
328 | 16 | 16 | ||
330 | 17 | import QtQuick 2.0 | 17 | import QtQuick 2.2 |
331 | 18 | import Ubuntu.Components 1.1 | ||
332 | 18 | 19 | ||
333 | 19 | // FIXME : move the API into Ubuntu.Components.Style | 20 | // FIXME : move the API into Ubuntu.Components.Style |
334 | 20 | Item { | 21 | Item { |
335 | @@ -48,7 +49,8 @@ | |||
336 | 48 | id: delegate | 49 | id: delegate |
337 | 49 | Rectangle { | 50 | Rectangle { |
338 | 50 | width: units.dp(1) | 51 | width: units.dp(1) |
340 | 51 | color: Theme.palette.selected.foreground | 52 | // FIXME: Add a new color to the palette |
341 | 53 | color: UbuntuColors.blue | ||
342 | 52 | } | 54 | } |
343 | 53 | } | 55 | } |
344 | 54 | 56 | ||
345 | 55 | 57 | ||
346 | === modified file 'modules/Ubuntu/Components/Themes/SuruDark/Palette.qml' | |||
347 | --- modules/Ubuntu/Components/Themes/SuruDark/Palette.qml 2014-07-11 15:11:02 +0000 | |||
348 | +++ modules/Ubuntu/Components/Themes/SuruDark/Palette.qml 2014-07-30 19:29:37 +0000 | |||
349 | @@ -35,7 +35,7 @@ | |||
350 | 35 | background: "#88D6D6D6" // FIXME: not from design | 35 | background: "#88D6D6D6" // FIXME: not from design |
351 | 36 | backgroundText: "#F3F3E7" | 36 | backgroundText: "#F3F3E7" |
352 | 37 | selection: Qt.rgba(UbuntuColors.blue.r, UbuntuColors.blue.g, UbuntuColors.blue.b, 0.2) | 37 | selection: Qt.rgba(UbuntuColors.blue.r, UbuntuColors.blue.g, UbuntuColors.blue.b, 0.2) |
354 | 38 | foreground: UbuntuColors.blue | 38 | foreground: UbuntuColors.orange |
355 | 39 | foregroundText: UbuntuColors.darkGrey | 39 | foregroundText: UbuntuColors.darkGrey |
356 | 40 | field: "#FFFFFF" | 40 | field: "#FFFFFF" |
357 | 41 | fieldText: "#888888" | 41 | fieldText: "#888888" |
358 | 42 | 42 | ||
359 | === modified file 'tests/autopilot/ubuntuuitoolkit/tests/gallery/test_buttons.py' | |||
360 | --- tests/autopilot/ubuntuuitoolkit/tests/gallery/test_buttons.py 2014-07-10 09:02:37 +0000 | |||
361 | +++ tests/autopilot/ubuntuuitoolkit/tests/gallery/test_buttons.py 2014-07-30 19:29:37 +0000 | |||
362 | @@ -34,7 +34,7 @@ | |||
363 | 34 | text="Call")), | 34 | text="Call")), |
364 | 35 | ('button with color', dict( | 35 | ('button with color', dict( |
365 | 36 | button_name="button_color", is_enabled=True, | 36 | button_name="button_color", is_enabled=True, |
367 | 37 | color=[174, 167, 159, 255], icon=None, text="Call")), | 37 | color=[0, 161, 50, 255], icon=None, text="Call")), |
368 | 38 | ('button with icon', dict( | 38 | ('button with icon', dict( |
369 | 39 | button_name="button_iconsource", is_enabled=True, color=None, | 39 | button_name="button_iconsource", is_enabled=True, color=None, |
370 | 40 | icon="call.png", text=None)), | 40 | icon="call.png", text=None)), |
150 + property color defaultColor: "#b2b2b2"
Can we use palette nor theme color here? Button color should be the most essential use case of theming.
107 + visible: !priv.removed && emptyListItem. swipingState === "" ? emptyListItem. selected || (emptyListItem. highlightWhenPr essed && emptyListItem. pressed) : false
Please indent this line so that the ? is on its own line as well as the : to make it easier to read (and less ridiculously long).