Ubuntu UI Toolkit

Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/more-visual-updates

  1. more-visual-updates
  2. Merge into staging
Revision history for this message
Cris Dywan (kalikiana) wrote :

150 + property color defaultColor: "#b2b2b2"

Can we use palette nor theme color here? Button color should be the most essential use case of theming.

107 + visible: !priv.removed && emptyListItem.swipingState === "" ? emptyListItem.selected || (emptyListItem.highlightWhenPressed && emptyListItem.pressed) : false

Please indent this line so that the ? is on its own line as well as the : to make it easier to read (and less ridiculously long).

review: Needs Fixing

« Back to merge proposal