Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/60-scectionScrolling

Revision history for this message
Tim Peeters (tpeeters) wrote :

I think I covered all these, except the width of the gradient (for which you say I need a spec) it is not clear what you mean.

> Feedback from Jamie:
>
> - We need to change the margins on the left (and right) of the sections to
> 2gu.
> - The gradient should be 2gu as well.
> . Can we adjust the height of the gradient so that it doesn't cover the
> underlines on each of the sections
> . We need to adjust the width of the gradient so that it's more obvious, we
> can barely see it. You'll need a spec for this…
> . Need to align the chevron on the overflow so that it aligns with the
> section labels
> - One other thing. When you select a section it jumps to the centre of the
> screen, this feels a wee bit odd as you quickly lose a sense of where you are
> in the navigation. Can you lose this functionality please.
> . We'd suggest that the sections only shift if one is partially visible on
> the left or right edges and only enough so that you can display the full
> section.

« Back to merge proposal