Merge into staging : 60-scectionScrolling : Code : Ubuntu UI Toolkit

Reviewer	Review Type	Date Requested	Status
ubuntu-sdk-build-bot	continuous-integration	2016-02-17	Approve on 2016-02-26
Cris Dywan		2016-02-17	Approve on 2016-02-26
PS Jenkins bot	continuous-integration	2016-02-17	Pending
Review via email: mp+286330@code.launchpad.net

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1777
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/328/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/953/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/328/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1777
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/104/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/954/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/104/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

PASSED: Continuous integration, rev:1777
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/338/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/958/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/338/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1777
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/80/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/959/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/80/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/35/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1779
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/329/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/961/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/329/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1779
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/105/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/962/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/105/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

PASSED: Continuous integration, rev:1779
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/339/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/963/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/339/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

FAILED: Continuous integration, rev:1779
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/81/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/964/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/81/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-17:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/36/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-02-19:

#

Feedback from Jamie:

- We need to change the margins on the left (and right) of the sections to 2gu.
- The gradient should be 2gu as well.
  . Can we adjust the height of the gradient so that it doesn't cover the underlines on each of the sections
  . We need to adjust the width of the gradient so that it's more obvious, we can barely see it. You'll need a spec for this…
  . Need to align the chevron on the overflow so that it aligns with the section labels
- One other thing. When you select a section it jumps to the centre of the screen, this feels a wee bit odd as you quickly lose a sense of where you are in the navigation. Can you lose this functionality please.
  . We'd suggest that the sections only shift if one is partially visible on the left or right edges and only enough so that you can display the full section.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1781
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/96/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1030/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/96/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1781
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/120/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1031/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/120/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1781
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/354/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1032/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/354/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1781
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/344/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1033/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/344/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/45/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1783
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/121/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1035/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/121/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1783
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/345/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1036/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/345/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

FAILED: Continuous integration, rev:1783
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/97/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1037/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/97/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

PASSED: Continuous integration, rev:1783
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/355/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1038/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/355/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/46/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

PASSED: Continuous integration, rev:1784
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/122/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1043/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/122/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

PASSED: Continuous integration, rev:1784
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/346/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1044/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/346/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

PASSED: Continuous integration, rev:1784
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/356/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1045/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/356/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

PASSED: Continuous integration, rev:1784
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/98/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1049/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/98/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-19:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/47/rebuild

review: Approve (continuous-integration)

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-02-19:

#

(Shift)Tab doesn't consistently switch between sections or from/ to sections - which is hard to tell in the first place as there's no focus ring - this branch was going to include that, which I asked to clarify before, but it doesn't.

Also, question, should the scroll arrows reveal instantly with no animation? It seems odd to me, but it probably is intentional, so just double-checking. UX is perfectly usable from my testing.

review: Needs Information

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-02-19:

#

This branch adds keyboard navigation, as it was in the prototype, with the left and right arrow keys. I will check with Jamie if that is the correct keyboard navigation. I will also ask the reveal arrow question.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1787
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/365/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1133/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/365/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1787
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/141/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1134/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/141/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1787
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/119/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1135/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/119/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1787
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/375/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1136/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/375/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/62/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1788
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/366/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1138/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/366/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1788
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/142/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1139/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/142/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1788
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/120/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1140/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/120/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1788
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/376/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1141/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/376/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/63/rebuild

review: Approve (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-02-22:

#

I think I covered all these, except the width of the gradient (for which you say I need a spec) it is not clear what you mean.

> Feedback from Jamie:
>
> - We need to change the margins on the left (and right) of the sections to
> 2gu.
> - The gradient should be 2gu as well.
> . Can we adjust the height of the gradient so that it doesn't cover the
> underlines on each of the sections
> . We need to adjust the width of the gradient so that it's more obvious, we
> can barely see it. You'll need a spec for this…
> . Need to align the chevron on the overflow so that it aligns with the
> section labels
> - One other thing. When you select a section it jumps to the centre of the
> screen, this feels a wee bit odd as you quickly lose a sense of where you are
> in the navigation. Can you lose this functionality please.
> . We'd suggest that the sections only shift if one is partially visible on
> the left or right edges and only enough so that you can display the full
> section.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

FAILED: Continuous integration, rev:1789
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/367/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1143/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/367/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1789
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/143/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1144/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/143/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1789
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/121/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1145/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/121/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1789
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/377/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1146/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/377/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

FAILED: Continuous integration, rev:1789
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/64/
Executed test runs:
    FAILURE: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/367/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/377
        deb: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/377/artifact/artifacts/*zip*/artifacts.zip
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/143
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/121
    None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1147/console
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1143
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1146
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1144
    SUCCESS: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1145

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/64/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1790
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/368/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1148/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/368/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1790
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/144/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1149/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/144/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1790
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/122/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1150/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/122/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

PASSED: Continuous integration, rev:1790
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/378/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1151/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/378/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-22:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/65/rebuild

review: Approve (continuous-integration)

Revision history for this message

Jamie Young (jamiedawsonyoung) wrote on 2016-02-23:

#

Hi Christian & Tim, to answer your questions…

You should be able to tab between the sections (says Femma).

There's no focus ring on a section as they work more like view switchers (in a similar way to a list view). Please let us know if you need clarification on this.

Scroll arrows should appear with a short animation. I would use the "Fast" speed from the sdk.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-23:

#

PASSED: Continuous integration, rev:1791
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/149/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1169/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/149/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-23:

#

PASSED: Continuous integration, rev:1791
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/373/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1170/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/373/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-23:

#

PASSED: Continuous integration, rev:1791
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/127/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1172/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/127/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-23:

#

PASSED: Continuous integration, rev:1791
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/383/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1175/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/383/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-23:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/69/rebuild

review: Approve (continuous-integration)

Revision history for this message

Femma (femma) wrote on 2016-02-24:

#

Hi Christian & Tim,

We had a discussion and after some investigation the solution is as follows:
-When in the sections, use the arrow key to move between the sections.
-The section will have a focus ring around it and a select highlight.
-The views should switch when focused on a tab (without having to hit space or enter to activate)

Please let me know if you need further clarification.

> Hi Christian & Tim, to answer your questions…
>
> You should be able to tab between the sections (says Femma).
>
> There's no focus ring on a section as they work more like view switchers (in a
> similar way to a list view). Please let us know if you need clarification on
> this.
>
> Scroll arrows should appear with a short animation. I would use the "Fast"
> speed from the sdk.

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1792
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/382/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1217/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/382/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1792
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/158/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1218/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/158/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1792
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/136/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1219/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/136/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

FAILED: Continuous integration, rev:1792
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/392/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1223/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/392/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/75/rebuild

review: Needs Fixing (continuous-integration)

lp:~tpeeters/ubuntu-ui-toolkit/60-scectionScrolling updated on 2016-02-25

1796. By Tim Peeters on 2016-02-25: link bug

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-02-25:

#

+++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-02-25 16:54:54 +0000
+// FocusScope { }

Please lose that line.

=== added file 'tests/Gallery/gallery'
=== removed file 'tests/Gallery/gallery'

This looks a bit suspicious...

review: Needs Fixing

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1795
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/392/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1266/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/392/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1795
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/168/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1267/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/168/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1795
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/402/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1268/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/402/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1795
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/146/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1269/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/146/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/84/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1796
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/170/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1274/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/170/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-25:

#

PASSED: Continuous integration, rev:1796
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/394/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1275/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/394/rebuild

review: Approve (continuous-integration)

Revision history for this message

Tim Peeters (tpeeters) wrote on 2016-02-26:

#

> +++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-02-25
> 16:54:54 +0000
> +// FocusScope { }
>
> Please lose that line.

done.

>
> === added file 'tests/Gallery/gallery'
> === removed file 'tests/Gallery/gallery'
>
> This looks a bit suspicious...

Right. I lost the file with a sync with another branch and I added it back again, which causes this message. The files are the same but I cannot convince bazaar not to show it in the diff.

lp:~tpeeters/ubuntu-ui-toolkit/60-scectionScrolling updated on 2016-02-26

1797. By Tim Peeters on 2016-02-26: sync staging
1798. By Tim Peeters on 2016-02-26: clean rogue // FocusScope { }

Revision history for this message

Cris Dywan (kalikiana) wrote on 2016-02-26:

#

Thanks!

review: Approve

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/398/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1297/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/398/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/174/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1298/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/174/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/152/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1299/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/152/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/408/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1300/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/408/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci/89/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/399/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1302/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-stable/399/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/175/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1303/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-amd64-devel/175/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/153/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1304/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-i386-gles-stable/153/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote on 2016-02-26:

#

PASSED: Continuous integration, rev:1798
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/409/
Executed test runs:
None: https://jenkins.ubuntu.com/ubuntu-sdk/job/generic-update-mp/1305/console

Click here to trigger a rebuild:
https://jenkins.ubuntu.com/ubuntu-sdk/job/ubuntu-ui-toolkit-ci-armhf-stable/409/rebuild

review: Approve (continuous-integration)

Revision history for this message

ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) on 2016-02-26:

#

review: Approve (continuous-integration)

Ubuntu UI Toolkit

Merge lp:~tpeeters/ubuntu-ui-toolkit/60-scectionScrolling into lp:ubuntu-ui-toolkit/staging

Commit message

Description of the change

Preview Diff

Subscribers

 === modified file 'examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml'
 --- examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml	2016-01-13 16:07:58 +0000
 +++ examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml	2016-02-26 10:16:56 +0000
@@ -44,8 +44,35 @@
                  iconName: "edit"
                  text: "Edit"
                  onTriggered: page.header = editHeader
++            },
++            Action {
++                iconName: standardHeader.extension === sections
++                          ? "media-playback-stop"
++                          : "filters"
++                text: "Sections"
++                onTriggered: {
++                    if (standardHeader.extension) {
++                        standardHeader.extension = null;
++                    } else {
++                        standardHeader.extension = sections;
++                    }
++                }
+             }
+         ]
++
++        Sections {
++            id: sections
++            visible: standardHeader.extension === sections
++            anchors {
++                left: parent.left
++                right: parent.right
++                bottom: parent.bottom
++            }
++            model: ["one", "two", "three", "four", "five", "six", "seven", "eight", "nine",
++                    "ten", "eleven", "twelve", "thirteen"]
++        }
++
++
+     }
      PageHeader {
 === modified file 'examples/ubuntu-ui-toolkit-gallery/Sections.qml'
 --- examples/ubuntu-ui-toolkit-gallery/Sections.qml	2015-10-23 14:46:16 +0000
 +++ examples/ubuntu-ui-toolkit-gallery/Sections.qml	2016-02-26 10:16:56 +0000
@@ -22,10 +22,39 @@
      id: sectionsTemplate
      header: PageHeader {
++        id: h
          title: sectionsTemplate.title
--        sections.model: ["first", "second", "third"]
++        extension: Sections {
++            anchors {
++                left: parent.left
++                right: parent.right
++                bottom: parent.bottom
++            }
++            model: h.showManySections ? sectionsTemplate.manyActions
++                                      : sectionsTemplate.fewActions
++        }
++        property bool showManySections: false
++        trailingActionBar.actions: [
++            Action {
++                iconName: h.showManySections ? "view-collapse" : "view-expand"
++                text: h.showManySections ? "less" : "more"
++                onTriggered: h.showManySections = !h.showManySections;
++            }
++        ]
+     }
++    property list<Action> fewActions: [
++        Action { text: "One" },
++        Action { text: "Two" },
++        Action { text: "Three" }
++    ]
++
++    property var manyActions: [
++        "one", "two", "three", "four", "five", "six", "seven", "eight", "nine",
++        "ten", "eleven", "twelve", "thirteen", "fourteen", "fifteen",
++        "sixteen", "seventeen", "eighteen", "nineteen", "twenty"
++    ]
++
      TemplateSection {
          title: "Sections"
          className: "Sections"
@@ -34,19 +63,38 @@
              title: i18n.tr("Enabled")
              Sections {
--                actions: [
--                    Action { text: "one" },
--                    Action { text: "two" },
--                    Action { text: "three" }
--                ]
--            }
--        }
--        TemplateRow {
--            title: i18n.tr("Disabled")
--
--            Sections {
--                model: ["one", "two", "three"]
--                enabled: false
++                actions: sectionsTemplate.fewActions
++            }
++        }
++        TemplateRow {
++            title: i18n.tr("Disabled")
++
++            Sections {
++                model: sectionsTemplate.fewActions
++                enabled: false
++            }
++        }
++    }
++
++    TemplateSection {
++        title: "Scrollable sections"
++        className: "Sections"
++
++        TemplateRow {
++            title: i18n.tr("Enabled")
++
++            Sections {
++                model: sectionsTemplate.manyActions
++                width: parent.width
++            }
++        }
++        TemplateRow {
++            title: i18n.tr("Disabled")
++
++            Sections {
++                model: sectionsTemplate.manyActions
++                enabled: false
++                width: parent.width
+             }
+         }
+     }
 === modified file 'src/Ubuntu/Components/1.3/Sections.qml'
 --- src/Ubuntu/Components/1.3/Sections.qml	2015-12-08 21:38:59 +0000
 +++ src/Ubuntu/Components/1.3/Sections.qml	2016-02-26 10:16:56 +0000
@@ -80,10 +80,6 @@
       */
      property var model: actions
      onModelChanged: {
--        if (model && model.length > 3) {
--            // FIXME: Make the Sections scrollable for more than 3 sections.
--            console.warn("It is not YET recommended or supported to use more than three sections.");
--        }
          if (internal.done) {
              if (!model || model.length === 0) {
                  selectedIndex = -1;
 === modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHead.qml'
 --- src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHead.qml	2015-12-08 22:05:42 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHead.qml	2016-02-26 10:16:56 +0000
@@ -25,14 +25,13 @@
   */
  StyledItem {
      id: sections
--    styleName: "SectionsStyle"
++    styleName: "SectionsForPageHeadStyle"
      property list<Action> actions
      property var model: actions
      onModelChanged: {
          if (model && model.length > 3) {
--            // FIXME: Make the Sections scrollable for more than 3 sections.
--            console.warn("It is not YET recommended or supported to use more than three sections.");
++            console.warn("PageHeadSections does not support more than 3 sections. Use PageHeader and Sections instead.");
+         }
+     }
      property int selectedIndex: model ? 0 : -1
 === added file 'src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHeadStyle.qml'
 --- src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHeadStyle.qml	1970-01-01 00:00:00 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsForPageHeadStyle.qml	2016-02-26 10:16:56 +0000
@@ -0,0 +1,122 @@
++/*
++ * Copyright 2016 Canonical Ltd.
++ *
++ * This program is free software; you can redistribute it and/or modify
++ * it under the terms of the GNU Lesser General Public License as published by
++ * the Free Software Foundation; version 3.
++ *
++ * This program is distributed in the hope that it will be useful,
++ * but WITHOUT ANY WARRANTY; without even the implied warranty of
++ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++ * GNU Lesser General Public License for more details.
++ *
++ * You should have received a copy of the GNU Lesser General Public License
++ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
++ */
++import QtQuick 2.4
++import Ubuntu.Components 1.3
++
++Item {
++    id: sectionsStyle
++
++    implicitWidth: sectionsRow.width
++    implicitHeight: units.gu(4)
++
++    enabled: styledItem.enabled
++
++    /*!
++      The foreground color of unselected sections.
++     */
++    property color sectionColor: enabled
++                                    ? theme.palette.normal.backgroundTertiaryText
++                                    : theme.palette.disabled.backgroundTertiaryText
++
++    /*!
++      The foreground color of the selected section.
++     */
++    property color selectedSectionColor: enabled
++                                            ? theme.palette.selected.backgroundTertiaryText
++                                            : theme.palette.selectedDisabled.backgroundTertiaryText
++
++    /*!
++      The background color for the pressed section button.
++     */
++    property color pressedBackgroundColor: theme.palette.highlighted.background
++
++    /*!
++      The font size for the text in the buttons.
++     */
++    property int textSize: Label.Small
++
++    /*!
++      The spacing on the left and right sides of the label
++      inside a section button.
++     */
++    property real horizontalLabelSpacing: units.gu(2)
++
++    /*!
++      The height of the bar underlining the sections.
++     */
++    property real underlineHeight: units.dp(2)
++
++    Row {
++        id: sectionsRow
++        anchors {
++            top: parent.top
++            bottom: parent.bottom
++            horizontalCenter: parent.horizontalCenter
++        }
++        width: childrenRect.width
++
++        Repeater {
++            id: sectionsRepeater
++            model: styledItem.model
++            objectName: "sections_repeater"
++            AbstractButton {
++                id: sectionButton
++                anchors {
++                    top: parent ? parent.top : undefined
++                    bottom: parent ? parent.bottom : undefined
++                }
++                objectName: "section_button_" + index
++                width: label.width + 2 * sectionsStyle.horizontalLabelSpacing
++                height: sectionsRow.height
++                property bool selected: index === styledItem.selectedIndex
++                onClicked: styledItem.selectedIndex = index
++
++                // Background pressed highlight
++                Rectangle {
++                    visible: parent.pressed
++                    anchors.fill: parent
++                    color: sectionsStyle.pressedBackgroundColor
++                }
++
++                // Section title
++                Label {
++                    id: label
++                    objectName: "section_button_label_" + index
++                    // modelData may be either a string, or an Action
++                    text: modelData.hasOwnProperty("text") ? modelData.text : modelData
++                    textSize: sectionsStyle.textSize
++                    anchors.centerIn: parent
++                    color: sectionButton.selected ?
++                               sectionsStyle.selectedSectionColor :
++                               sectionsStyle.sectionColor
++                }
++
++                // Section title underline
++                Rectangle {
++                    anchors {
++                        bottom: parent.bottom
++                        left: parent.left
++                        right: parent.right
++                    }
++                    height: sectionsStyle.underlineHeight
++                    color: sectionButton.selected ?
++                               sectionsStyle.selectedSectionColor :
++                               sectionsStyle.sectionColor
++                }
++            }
++        }
++    }
++}
 === modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml'
 --- src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml	2016-01-27 15:17:56 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml	2016-02-26 10:16:56 +0000
@@ -15,28 +15,33 @@
   */
  import QtQuick 2.4
  import Ubuntu.Components 1.3
++import QtGraphicalEffects 1.0
++import Ubuntu.Components.Private 1.3
  Item {
      id: sectionsStyle
--    implicitWidth: sectionsRow.width
++    implicitWidth: sectionsListView.contentWidth + 2 * listViewContainer.listViewMargins
      implicitHeight: units.gu(4)
--    enabled: styledItem.enabled
--
      /*!
        The foreground color of unselected sections.
       */
      property color sectionColor: enabled
--                                    ? theme.palette.normal.backgroundTertiaryText
--                                    : theme.palette.disabled.backgroundTertiaryText
++                                 ? theme.palette.normal.backgroundTertiaryText
++                                 : theme.palette.disabled.backgroundTertiaryText
++
++    /*!
++      The foreground color of underline rectangle of unselected sections.
++     */
++    property color underlineColor: theme.palette.normal.base
      /*!
        The foreground color of the selected section.
       */
      property color selectedSectionColor: enabled
--                                            ? theme.palette.selected.backgroundTertiaryText
--                                            : theme.palette.selectedDisabled.backgroundTertiaryText
++                                         ? theme.palette.selected.backgroundTertiaryText
++                                         : theme.palette.selectedDisabled.backgroundTertiaryText
      /*!
        The background color for the pressed section button.
@@ -44,9 +49,9 @@
      property color pressedBackgroundColor: theme.palette.highlighted.background
      /*!
--      The font size for the text in the buttons.
++      The size of text in the buttons.
       */
--    property int textSize: Label.Small
++    property int textSize: Label.Medium
      /*!
        The spacing on the left and right sides of the label
@@ -59,30 +64,132 @@
       */
      property real underlineHeight: units.dp(2)
--    Row {
--        id: sectionsRow
--        anchors {
--            top: parent.top
--            bottom: parent.bottom
--            horizontalCenter: parent.horizontalCenter
--        }
--        width: childrenRect.width
--
--        Repeater {
--            id: sectionsRepeater
++    // We don't clip listview on purpose, so we have to clip here to prevent Sections element
++    // from painting outside its area.
++    clip: true
++
++    //This item is needed for the OpacityMask feature. It is needed to make sure that when we
++    //bring a list element into view, that element won't be covered by the opacity mask. So we
++    //disable clipping on the list but we give it margins. This way when an item is repositioned
++    //to be within the listview, that item will not be positioned under the opacity mask. (which is
++    //what would have happened if the listview were filling the parent)
++    Item {
++        id: listViewContainer
++        anchors.fill: parent
++
++        property real listViewMargins: units.gu(2)
++
++        //We need to set this to 0.0 when OpacityMask will draw this listview for us.
++        //we don't set visible: false because we still want to get the input events!
++        opacity: 1.0
++
++        ListView {
++            id: sectionsListView
++            objectName: "sections_listview"
++
++            property bool animateContentX: false
++            activeFocusOnTab: false // FIXME: Enable proper focus handling
++
++            // Position the selected item correctly.
++            // For a scrollable ListView, if the item was already fully visible,
++            //  no repositioning is needed. If the item was (partially) invisible,
++            //  position it so that it becomes fully visible.
++            // If the ListView is not scrollable, the first item will be aligned with
++            //  the left of the ListView.
++            function positionItem(item) {
++                if (item !== null) {
++                    //stop the flick before doing computations
++                    if (moving) {
++                        return;
++                    }
++                    if (dragging || flicking) {
++                        cancelFlick();
++                    }
++                    if (contentXAnim.running) {
++                        contentXAnim.stop();
++                    }
++
++                    contentXAnim.from = contentX;
++                    //make sure we don't overshoot bounds
++                    if (sectionsListView.contentWidth <= sectionsListView.width) {
++                        // No scrolling, position the sections on the left.
++                        contentXAnim.to = originX;
++                    } else {
++                        // Position the selected Item so that it is fully visible.
++                        contentXAnim.to = MathUtils.clamp(contentX, originX, originX + contentWidth - width);
++                    }
++                    if (contentXAnim.from !== contentXAnim.to) {
++                        contentXAnim.start();
++                    }
++                }
++            }
++
++            anchors {
++                fill: parent
++                leftMargin: listViewContainer.listViewMargins
++                rightMargin: listViewContainer.listViewMargins
++            }
++
++            //this is just to disable keyboard navigation to avoid messing with contentX/contentWidth while
++            //the view is moving
++            focus: !moving
++
++            onWidthChanged: positionItem(currentItem)
++            //make sure that the currentItem is in the middle when everything is initialized
++            Component.onCompleted: positionItem(currentItem)
++
++            orientation: ListView.Horizontal
++            boundsBehavior: Flickable.StopAtBounds
++
              model: styledItem.model
--            objectName: "sections_repeater"
--            AbstractButton {
++
++            //We need this to make sure that we have delegates for the whole width, since we have
++            //clip disabled.
++            displayMarginBeginning: listViewContainer.listViewMargins
++            displayMarginEnd: listViewContainer.listViewMargins
++
++            currentIndex: styledItem.selectedIndex
++            onCurrentIndexChanged: {
++                styledItem.selectedIndex = currentIndex;
++            }
++            onCurrentItemChanged: {
++                //adjust contentX so that the item is kept in the middle
++                //don't use ListView.ApplyRange because that does an awkward animation when you select an item
++                //*while* the current item is outside of screen
++                positionItem(currentItem);
++            }
++
++            highlightFollowsCurrentItem: false
++            highlight: Item {
++                //show the highlight on top of the delegate
++                z: 2
++                x: sectionsListView.currentItem ? sectionsListView.currentItem.x : -width
++                width: sectionsListView.currentItem ? sectionsListView.currentItem.width : 0
++                height: sectionsListView.currentItem ? sectionsListView.currentItem.height : 0
++
++                Rectangle {
++                    anchors {
++                        bottom: parent.bottom
++                        left: parent.left
++                        right: parent.right
++                    }
++                    height: sectionsStyle.underlineHeight
++                    color: sectionsStyle.selectedSectionColor
++                }
++                Behavior on x { UbuntuNumberAnimation {} }
++            }
++
++            delegate: AbstractButton {
                  id: sectionButton
--                anchors {
--                    top: parent ? parent.top : undefined
--                    bottom: parent ? parent.bottom : undefined
--                }
++                activeFocusOnTab: false
                  objectName: "section_button_" + index
                  width: label.width + 2 * sectionsStyle.horizontalLabelSpacing
--                height: sectionsRow.height
++                height: sectionsStyle.height
                  property bool selected: index === styledItem.selectedIndex
--                onClicked: styledItem.selectedIndex = index
++                onClicked: {
++                    styledItem.selectedIndex = index;
++                    sectionsListView.forceActiveFocus();
++                }
                  // Background pressed highlight
                  Rectangle {
@@ -98,25 +205,189 @@
                      // modelData may be either a string, or an Action
                      text: modelData.hasOwnProperty("text") ? modelData.text : modelData
                      textSize: sectionsStyle.textSize
--                    anchors.centerIn: parent
++                    font.weight: Font.Light
++                    anchors {
++                        baseline: underline.bottom
++                        baselineOffset: -units.gu(2)
++                        horizontalCenter: parent.horizontalCenter
++                    }
++
                      color: sectionButton.selected ?
                                 sectionsStyle.selectedSectionColor :
                                 sectionsStyle.sectionColor
++
++                    Behavior on color {
++                        ColorAnimation { duration: UbuntuAnimation.SlowDuration }
++                    }
+                 }
                  // Section title underline
                  Rectangle {
++                    id: underline
                      anchors {
                          bottom: parent.bottom
                          left: parent.left
                          right: parent.right
+                     }
                      height: sectionsStyle.underlineHeight
--                    color: sectionButton.selected ?
--                               sectionsStyle.selectedSectionColor :
--                               sectionsStyle.sectionColor
--                }
--            }
--        }
--    }
++                    color: sectionsStyle.underlineColor
++                }
++            }
++
++            SmoothedAnimation {
++                id: contentXAnim
++                target: sectionsListView
++                property: "contentX"
++                duration: UbuntuAnimation.FastDuration
++                velocity: units.gu(10)
++            }
++        }
++    }
++
++    MouseArea {
++        // Detect hovering over the left and right areas to show the scrolling chevrons.
++        id: hoveringArea
++
++        property real iconsDisabledOpacity: 0.3
++
++        property bool hoveringLeft: false
++        property bool hoveringRight: false
++
++        function checkHovering(mouse) {
++            if (mouse.x < listViewContainer.listViewMargins) {
++                if (!hoveringLeft) hoveringLeft = true;
++            } else if (mouse.x > width - listViewContainer.listViewMargins) {
++                if (!hoveringRight) hoveringRight = true;
++            } else {
++                hoveringLeft = false;
++                hoveringRight = false;
++            }
++        }
++
++        anchors.fill: parent
++        hoverEnabled: true
++
++        onPositionChanged: checkHovering(mouse)
++        onExited: {
++            hoveringLeft = false;
++            hoveringRight = false;
++        }
++        onPressed: {
++            if (!hoveringLeft && !hoveringRight) {
++                mouse.accepted = false;
++            }
++        }
++        onClicked: {
++            // positionViewAtIndex() does not provide animation
++            if (contentXAnim.running) contentXAnim.stop();
++            var newContentX = sectionsListView.contentX + (sectionsListView.width * (hoveringLeft ? -1 : 1));
++            contentXAnim.from = sectionsListView.contentX;
++            // make sure we don't overshoot bounds
++            contentXAnim.to = MathUtils.clamp(
++                        newContentX,
++                        sectionsListView.originX,
++                        sectionsListView.originX + sectionsListView.contentWidth - sectionsListView.width);
++            contentXAnim.start();
++        }
++
++        Icon {
++            id: leftHoveringIcon
++            anchors {
++                left: parent.left
++                leftMargin: (listViewContainer.listViewMargins - width) / 2
++                bottom: parent.bottom
++                bottomMargin: units.gu(2)
++            }
++            width: units.gu(1)
++            height: units.gu(1)
++            visible: false
++            rotation: 180
++            opacity: visible
++                     ? sectionsListView.atXBeginning ? hoveringArea.iconsDisabledOpacity : 1.0
++                     : 0.0
++            name: "chevron"
++            Behavior on opacity {
++                UbuntuNumberAnimation {
++                    duration: UbuntuAnimation.FastDuration
++                }
++            }
++        }
++
++        Icon {
++            id: rightHoveringIcon
++            anchors {
++                right: parent.right
++                rightMargin: (listViewContainer.listViewMargins - width) / 2
++                bottom: parent.bottom
++                bottomMargin: units.gu(2)
++            }
++            width: units.gu(1)
++            height: units.gu(1)
++            visible: false
++            opacity: visible
++                     ? sectionsListView.atXEnd ? hoveringArea.iconsDisabledOpacity : 1.0
++                     : 0.0
++            name: "chevron"
++            Behavior on opacity {
++                UbuntuNumberAnimation {
++                    duration: UbuntuAnimation.FastDuration
++                }
++            }
++        }
++    }
++
++    LinearGradient {
++        id: gradient
++
++        visible: false
++        anchors.fill: parent
++        start: Qt.point(0,0)
++        end: Qt.point(width,0)
++
++        property real gradientWidth: listViewContainer.listViewMargins / gradient.width
++        //the width is gradientWidth, but we want the gradient to actually start/finish at gradientSplitPosition
++        //just to leave some margin.
++        property real gradientSplitPosition: 2/3 * gradientWidth
++
++        gradient: Gradient {
++            //left gradient
++            GradientStop { position: 0.0 ; color: Qt.rgba(1,1,1,0) }
++            GradientStop { position: gradient.gradientSplitPosition ; color: Qt.rgba(1,1,1,0) }
++            GradientStop { position: gradient.gradientWidth; color: Qt.rgba(1,1,1,1) }
++            //right gradient
++            GradientStop { position: 1.0 - gradient.gradientWidth; color: Qt.rgba(1,1,1,1) }
++            GradientStop { position: 1.0 - gradient.gradientSplitPosition; color: Qt.rgba(1,1,1,0) }
++            GradientStop { position: 1.0; color: Qt.rgba(1,1,1,0) }
++        }
++
++            Rectangle {
++                // full opacity for the underline at the bottom in the mask below
++                anchors {
++                    left: parent.left
++                    right: parent.right
++                    bottom: parent.bottom
++                }
++                height: sectionsStyle.underlineHeight
++                color: "white"
++            }
++    }
++
++    OpacityMask {
++        id: mask
++        anchors.fill: parent
++        visible: false
++        source: listViewContainer
++        maskSource: gradient
++    }
++
++    states: [
++        State {
++            name: "hovering"
++            when: hoveringArea.containsMouse
++            PropertyChanges { target: mask; visible: true }
++            PropertyChanges { target: listViewContainer; opacity: 0.0 }
++            PropertyChanges { target: leftHoveringIcon; visible: true; }
++            PropertyChanges { target: rightHoveringIcon; visible: true; }
++        }
++    ]
+ }
 === modified file 'src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro'
 --- src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro	2016-01-22 19:42:49 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/Ambiance.pro	2016-02-26 10:16:56 +0000
@@ -119,6 +119,7 @@
 .3/BottomEdgeStyle.qml \
 .3/FocusShape.qml \
 .3/SectionsForPageHead.qml \
++	     1.3/SectionsForPageHeadStyle.qml \
               $$ARTWORK_FILES
  load(ubuntu_qml_module)
 === modified file 'src/Ubuntu/Components/Themes/Ambiance/qmldir'
 --- src/Ubuntu/Components/Themes/Ambiance/qmldir	2016-01-13 14:25:22 +0000
 +++ src/Ubuntu/Components/Themes/Ambiance/qmldir	2016-02-26 10:16:56 +0000
@@ -89,3 +89,4 @@
  BottomEdgeStyle 1.3 ./1.3/BottomEdgeStyle.qml
  ToolbarStyle 1.3 ./1.3/ToolbarStyle.qml
  internal SectionsForPageHead ./1.3/SectionsForPageHead.qml
++internal SectionsForPageHeadStyle ./1.3/SectionsForPageHeadStyle.qml
 === added file 'tests/Gallery/gallery'
 --- tests/Gallery/gallery	1970-01-01 00:00:00 +0000
 +++ tests/Gallery/gallery	2016-02-26 10:16:56 +0000
@@ -0,0 +1,6 @@
++#!/bin/bash
++
++. `dirname ${BASH_SOURCE[0]}`/../../export_modules_dir.sh || exit 1
++
++SCRIPT_DIRECTORY=`dirname $0`
++QT_LOGGING_CONF=$SCRIPT_DIRECTORY/gallery-logging.config $BUILD_DIR/ubuntu-ui-toolkit-launcher/ubuntu-ui-toolkit-launcher $@ $SCRIPT_DIRECTORY/../../examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml
 === removed file 'tests/Gallery/gallery'
 --- tests/Gallery/gallery	2016-02-04 12:02:52 +0000
 +++ tests/Gallery/gallery	1970-01-01 00:00:00 +0000
@@ -1,6 +0,0 @@
--#!/bin/bash
--
--. `dirname ${BASH_SOURCE[0]}`/../../export_modules_dir.sh || exit 1
--
--SCRIPT_DIRECTORY=`dirname $0`
--QT_LOGGING_CONF=$SCRIPT_DIRECTORY/gallery-logging.config $BUILD_DIR/ubuntu-ui-toolkit-launcher/ubuntu-ui-toolkit-launcher $@ $SCRIPT_DIRECTORY/../../examples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml
 === modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_sections.py'
 --- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_sections.py	2015-05-28 15:38:53 +0000
 +++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_sections.py	2016-02-26 10:16:56 +0000
@@ -1,6 +1,6 @@
  # -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+ #
--# Copyright (C) 2015 Canonical Ltd.
++# Copyright (C) 2016 Canonical Ltd.
+ #
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU Lesser General Public License as published by
@@ -27,15 +27,9 @@
  class Sections(_common.UbuntuUIToolkitCustomProxyObjectBase):
      """Sections Autopilot custom proxy object."""
--    def _get_section_button(self, section_index):
--        try:
--            object_name = "section_button_" + str(section_index)
--            button = self.select_single(objectName=object_name)
--        except dbus.StateNotFoundError:
--            raise _common.ToolkitException(
--                'Button not found in Sections.')
--
--        return button
++    def __init__(self, *args):
++        super().__init__(*args)
++        self.listview = self.select_single(objectName='sections_listview')
      @autopilot_logging.log_action(logger.info)
      def click_section_button(self, section_index):
@@ -45,5 +39,10 @@
          :raise ToolkitException: If there is no section button with that index.
          """
--        button = self._get_section_button(section_index)
--        self.pointing_device.click_object(button)
++        button_object_name = 'section_button_' + str(section_index)
++        try:
++            self.listview.click_element(button_object_name)
++        except _common.ToolkitException:
++            raise _common.ToolkitException(
++                'Button with section index ' + str(section_index) +
++                ' not found in Sections.')
 === modified file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.SectionsTestCase.qml'
 --- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.SectionsTestCase.qml	2015-05-28 15:48:42 +0000
 +++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.SectionsTestCase.qml	2016-02-26 10:16:56 +0000
@@ -1,5 +1,5 @@
  /*
-- * Copyright 2015 Canonical Ltd.
++ * Copyright 2016 Canonical Ltd.
+  *
   * This program is free software; you can redistribute it and/or modify
   * it under the terms of the GNU Lesser General Public License as published by
@@ -22,12 +22,16 @@
      height: units.gu(60)
      objectName: "mainView"
      Page {
--        title: "Sections test"
++        id: page
++        header: PageHeader {
++            title: "Sections test"
++        }
          Label {
              id: label
              objectName: "label"
              anchors {
--                top: parent.top
++                top: page.header.bottom
++                topMargin: units.gu(2)
                  horizontalCenter: parent.horizontalCenter
+             }
              text: "Section " + sections.selectedIndex + " is selected."
@@ -35,8 +39,36 @@
          Sections {
              id: sections
              objectName: "sections"
--            anchors.centerIn: parent
++            anchors {
++                horizontalCenter: parent.horizontalCenter
++                top: label.bottom
++                topMargin: units.gu(4)
++            }
              model: [ "first", "second", "third" ]
+         }
++        Label {
++            id: moreLabel
++            objectName: "scrolling_label"
++            anchors {
++                centerIn: parent
++            }
++            text: "Scrollable section " + moreSections.selectedIndex + " is selected."
++        }
++        Sections {
++            id: moreSections
++            objectName: "scrolling_sections"
++            anchors {
++                horizontalCenter: parent.horizontalCenter
++                top: moreLabel.bottom
++                topMargin: units.gu(4)
++                left: parent.left
++                right: parent.right
++            }
++            model: ["one", "two", "three", "four", "five", "six",
++                "seven", "eight", "nine", "ten", "eleven", "twelve",
++                "thirteen", "fourteen", "fifteen", "sixteen",
++                "seventeen", "eighteen", "nineteen", "twenty"
++            ]
++        }
+     }
+ }
 === modified file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py'
 --- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py	2015-11-11 17:37:14 +0000
 +++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_sections.py	2016-02-26 10:16:56 +0000
@@ -29,21 +29,45 @@
      def setUp(self):
          super().setUp()
          self.sections = self.app.select_single(objectName='sections')
++        self.scrollingSections = self.app.select_single(objectName='scrolling_sections')
          self.label = self.app.select_single(objectName='label')
++        self.scrollingLabel = self.app.select_single(objectName='scrolling_label')
          self.assertEqual(self.label.text, 'Section 0 is selected.')
++        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 0 is selected.')
      def test_custom_proxy_object(self):
          self.assertIsInstance(self.sections, ubuntuuitoolkit.Sections)
          self.assertTrue(self.sections.visible)
++        self.assertIsInstance(self.scrollingSections, ubuntuuitoolkit.Sections)
++        self.assertTrue(self.scrollingSections.visible)
      def test_click_section_button(self):
          self.sections.click_section_button(2)
          self.assertEqual(self.label.text, 'Section 2 is selected.')
++    def test_click_visible_scrolling_section_button(self):
++        self.scrollingSections.click_section_button(2)
++        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 2 is selected.')
++
++    def test_scroll_and_click_section_button(self):
++        # scroll forward and click:
++        self.scrollingSections.click_section_button(15)
++        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 15 is selected.')
++        # scroll back and click:
++        self.scrollingSections.click_section_button(1)
++        self.assertEqual(self.scrollingLabel.text, 'Scrollable section 1 is selected.')
++
      def test_click_unexisting_section_button(self):
          error = self.assertRaises(
              ubuntuuitoolkit.ToolkitException,
              self.sections.click_section_button, 3)
          self.assertEqual(
              str(error),
--            'Button not found in Sections.')
++            'Button with section index 3 not found in Sections.')
++
++        error = self.assertRaises(
++            ubuntuuitoolkit.ToolkitException,
++            self.scrollingSections.click_section_button, 20)
++        self.assertEqual(
++            str(error),
++            'Button with section index 20 not found in Sections.')
 === modified file 'tests/unit_x11/tst_components/tst_pagehead_sections.qml'
 --- tests/unit_x11/tst_components/tst_pagehead_sections.qml	2015-12-08 14:26:27 +0000
 +++ tests/unit_x11/tst_components/tst_pagehead_sections.qml	2016-02-26 10:16:56 +0000
@@ -136,7 +136,7 @@
+         }
          function test_warn_when_too_many_sections() {
--            ignoreWarning("It is not YET recommended or supported to use more than three sections.")
++            ignoreWarning("PageHeadSections does not support more than 3 sections. Use PageHeader and Sections instead.");
              page.head.sections.model = ["red", "orange", "yellow", "green"];
+         }
+     }
 === modified file 'tests/unit_x11/tst_components/tst_pagehead_sections_bug1511839.qml'
 --- tests/unit_x11/tst_components/tst_pagehead_sections_bug1511839.qml	2015-11-02 15:20:42 +0000
 +++ tests/unit_x11/tst_components/tst_pagehead_sections_bug1511839.qml	2016-02-26 10:16:56 +0000
@@ -62,7 +62,7 @@
          function test_bug1511839() {
              for (var i = 0; i < stack.currentPage.head.sections.model.length; i++) {
--                verifySelectedSection(i, false);
++                verifySelectedSection(i, false, "Section " + i + " is selected.");
+             }
+         }
 === modified file 'tests/unit_x11/tst_components/tst_sections.qml'
 --- tests/unit_x11/tst_components/tst_sections.qml	2015-12-08 21:35:11 +0000
 +++ tests/unit_x11/tst_components/tst_sections.qml	2016-02-26 10:16:56 +0000
@@ -20,27 +20,34 @@
  Rectangle {
      id: root
--    width: 400
--    height: 600
++    width: units.gu(60)
++    height: units.gu(75)
      color: "white"
      property list<Action> actionList: [
          Action {
--            text: "first";
++            text: "action 0";
              onTriggered: label.text = "First action triggered.";
          },
          Action {
--            text: "second";
++            text: "action 1";
              onTriggered: label.text = "Second action triggered.";
          },
          Action {
--            text: "third";
++            text: "action 2";
              onTriggered: label.text = "Third action triggered.";
+         }
+     ]
      property var stringList: [
--        "string one", "string two", "string three"
++        "string zero", "string one", "string two"
++    ]
++
++    property var longStringList: [
++        "one", "two", "three", "four", "five", "six", "seven",
++        "eight", "nine", "ten", "eleven", "twelve", "thirteen",
++        "fourteen", "fifteen", "sixteen", "seventeen",
++        "eighteen", "nineteen", "twenty"
+     ]
      Column {
@@ -53,41 +60,15 @@
+         }
          spacing: units.gu(2)
--        Label {
--            anchors.horizontalCenter: parent.horizontalCenter
--            text: "Sections with actions"
--        }
--        Label {
--            anchors.left: parent.left
--            text: "actions in-line:"
--            textSize: Label.Small
--        }
          Sections {
              // Not used in the tests below, but added here to
              //  verify that the Actions can be defined directly
              //  inside the list of actions.
              actions: [
--                Action { text: "1" },
--                Action { text: "2" }
++                Action { text: "inline action 0" },
++                Action { text: "inline action 1" }
+             ]
--        }
--        Label {
--            anchors.left: parent.left
--            text: "enabled:"
--            textSize: Label.Small
--        }
--        Sections {
--            id: enabledSections
--            actions: root.actionList
--        }
--        Label {
--            text: "disabled:"
--            textSize: Label.Small
--        }
--        Sections {
--            id: disabledSections
--            actions: root.actionList
--            enabled: false
++            width: parent.width
+         }
          Rectangle {
              anchors {
@@ -96,7 +77,7 @@
                  margins: units.gu(2)
+             }
              color: UbuntuColors.blue
--            height: units.gu(10)
++            height: units.gu(5)
              Label {
                  id: label
                  anchors.centerIn: parent
@@ -104,24 +85,24 @@
                  color: "white"
+             }
+         }
--        Label {
--            anchors.horizontalCenter: parent.horizontalCenter
--            text: "Sections with strings"
--        }
--        Label {
--            anchors.left: parent.left
--            text: "enabled:"
--            textSize: Label.Small
++        Sections {
++            id: enabledSections
++            actions: root.actionList
++        }
++        Sections {
++            id: disabledSections
++            actions: root.actionList
++            enabled: false
++        }
++        Sections {
++            id: noSelectionSections
++            actions: root.actionList
++            selectedIndex: -1
+         }
          Sections {
              id: enabledStringSections
              model: root.stringList
+         }
--        Label {
--            anchors.left: parent.left
--            text: "disabled:"
--            textSize: Label.Small
--        }
          Sections {
              id: disabledStringSections
              model: root.stringList
@@ -133,17 +114,25 @@
              property bool action1Triggered: false;
              property bool action2Triggered: false;
              property Action action0: Action {
++                text: "action0"
                  onTriggered: selectedIndexSections.action0Triggered = true;
+             }
              property Action action1: Action {
++                text: "action1 (selected)"
                  onTriggered: selectedIndexSections.action1Triggered = true;
+             }
              property Action action2: Action {
++                text: "action2"
                  onTriggered: selectedIndexSections.action2Triggered = true;
+             }
              actions: [action0, action1, action2]
              selectedIndex: 1
+         }
++        Sections {
++            id: scrollingSections
++            model: root.longStringList
++            width: parent.width
++        }
+     }
      UbuntuTestCase {
@@ -176,8 +165,8 @@
+         }
          function get_number_of_section_buttons(sections) {
--            var repeater = findChild(sections, "sections_repeater");
--            return repeater.count;
++            var listview = findChild(sections, "sections_listview");
++            return listview.count;
+         }
          // return the index of the selected section button,
@@ -224,28 +213,31 @@
          function check_selected_section(sections, index, name) {
              var v = sections.selectedIndex;
--            compare(v, index, "selectedIndex "+v+" does not match "+index);
++            compare(v, index, "selectedIndex " + v + " does not match " + index);
              v = get_selected_section_button_index(sections);
--            compare(v, index, "selected button index "+v+" does not match "+index);
++            compare(v, index, "selected button index " + v + " does not match " + index);
              if (v === -1) return;
              var w = get_selected_section_button_text(sections);
--            compare(w, name, "selected button text \'"+w+"\' does not match \'"+name+"\'");
++            compare(w, name, "selected button text \'" + w + "\' does not match \'" + name + "\'");
+         }
          // in each test function below, test the desired behavior
          //  for both enabledSections and disabledSections.
          function test_0_first_section_initially_selected_actions_enabled() {
--            check_selected_section(enabledSections, 0, "first");
++            check_selected_section(enabledSections, 0, "action 0");
+         }
          function test_0_first_section_initially_selected_actions_disabled() {
--            check_selected_section(disabledSections, 0, "first");
++            check_selected_section(disabledSections, 0, "action 0");
+         }
          function test_0_first_section_initially_selected_strings_enabled() {
--            check_selected_section(enabledStringSections, 0, "string one");
++            check_selected_section(enabledStringSections, 0, "string zero");
+         }
          function test_0_first_section_initially_selected_strings_disabled() {
--            check_selected_section(disabledStringSections, 0, "string one");
++            check_selected_section(disabledStringSections, 0, "string zero");
++        }
++        function test_0_no_selected_section_initalization() {
++            check_selected_section(noSelectionSections, -1, "");
+         }
          function test_number_of_section_buttons() {
@@ -258,7 +250,7 @@
          function test_click_to_select_section_and_trigger_action() {
              var index = 2;
--            var name = "third";
++            var name = "action 2";
              click_section_button(enabledSections, name);
              wait_for_animation(enabledSections);
              check_selected_section(enabledSections, index, name);
@@ -268,12 +260,12 @@
          function test_click_disabled_section_action() {
              var index = 2;
--            var name = "third";
++            var name = "action 2";
              click_section_button(disabledSections, name);
              wait_for_animation(disabledSections);
              // first button should still be selected:
              index = 0;
--            name = "first";
++            name = "action 0";
              check_selected_section(disabledSections, index, name);
              var text = "No action triggered.";
              compare(label.text, text, "Clicking disabled button triggered something.");
@@ -281,25 +273,25 @@
          function test_click_to_select_section_string() {
              var index = 2;
--            var name = "string three";
++            var name = "string two";
              click_section_button(enabledStringSections, name);
              wait_for_animation(enabledStringSections);
              check_selected_section(enabledStringSections, index, name);
+         }
          function test_click_disabled_section_string() {
--            var name = "string three";
++            var name = "string two";
              click_section_button(disabledStringSections, name);
              wait_for_animation(disabledStringSections);
              // first button should still be selected:
              var index = 0;
--            name = "string one";
++            name = "string zero";
              check_selected_section(disabledStringSections, index, name);
+         }
          function test_set_selectedIndex_to_select_section_and_trigger_action_enabled() {
              var index = 1;
--            var name = "second";
++            var name = "action 1";
              enabledSections.selectedIndex = index;
              wait_for_animation(enabledSections);
              check_selected_section(enabledSections, index, name);
@@ -309,7 +301,7 @@
          function test_set_selectedIndex_to_select_section_and_trigger_action_disabled() {
              var index = 2;
--            var name = "third";
++            var name = "action 2";
              disabledSections.selectedIndex = index;
              wait_for_animation(disabledSections);
              check_selected_section(disabledSections, index, name);
@@ -320,7 +312,7 @@
          function test_set_selectedIndex_to_select_section_string_enabled() {
              var index = 1;
--            var name = "string two";
++            var name = "string one";
              enabledStringSections.selectedIndex = index;
              wait_for_animation(enabledStringSections);
              check_selected_section(enabledStringSections, index, name);
@@ -328,7 +320,7 @@
          function test_set_selectedIndex_to_select_section_string_disabled() {
              var index = 2;
--            var name = "string three";
++            var name = "string two";
              disabledStringSections.selectedIndex = index;
              check_selected_section(disabledStringSections, index, name);
+         }
@@ -371,5 +363,66 @@
              selectedIndexSections.actions = originalActions;
              wait_for_animation(selectedIndexSections);
+         }
++
++        function test_keyboard_navigation_data() {
++            return [
++                        { tag: "actions",
++                            item: enabledSections,
++                            initialButton: root.actionList[0].text,
++                            initialIndex: 0
++                        },
++                        { tag: "strings",
++                            item: enabledStringSections,
++                            initialButton: root.stringList[0],
++                            initialIndex: 0
++                        },
++                        { tag: "scrolling",
++                            item: scrollingSections,
++                            initialButton: root.longStringList[0],
++                            initialIndex: 0
++                        }
++                    ];
++        }
++
++        function test_keyboard_navigation(data) {
++            var sections = data.item;
++            var initialButtonName = data.initialButton;
++            click_section_button(sections, initialButtonName);
++            wait_for_animation(sections);
++            compare(sections.selectedIndex, data.initialIndex,
++                    "Clicking the initial button does not select section "+data.initialIndex);
++            var numberOfSections = sections.model.length;
++            var i = sections.selectedIndex;
++
++            // Sections has focus because it was just clicked on,
++            //  so we can use keyboard navigation.
++            while (i < numberOfSections - 1) {
++                i++;
++                keyClick(Qt.Key_Right);
++                wait_for_animation(sections);
++                compare(sections.selectedIndex, i,
++                        "Could not navigate to index " + i + " using right key.");
++            }
++
++            // Navigated to the last section. Right key should do nothing now.
++            keyClick(Qt.Key_Right);
++            wait_for_animation(sections);
++            compare(sections.selectedIndex, i,
++                    "Using right key navigates beyond the last section.");
++
++            while (i > 0) {
++                i--;
++                keyClick(Qt.Key_Left);
++                wait_for_animation(sections);
++                compare(sections.selectedIndex, i,
++                        "Could not navigate back to index " + i + " using left key.");
++            }
++
++            // Navigated back to the beginning. Left key should do nothing now.
++            keyClick(Qt.Key_Left);
++            wait_for_animation(sections);
++            compare(sections.selectedIndex, i,
++                    "Using left key navigates beyond the first section.");
++        }
+     }
+ }