Code review comment for ~tore.lonoy/cloud-init:hashed-chpasswd-support

Revision history for this message
Scott Moser (smoser) wrote :

this looks good. I marked 'Needs Fixing', just for a few nit picks.

I'd like some sort of unit test too.

The trend for adding unit tests is really to make 'handle' do less and move things into methods and use those methods.

review: Needs Fixing

« Back to merge proposal