Code review comment for lp:~tom-gall/linaro/fix-752843-live-helper.config.natty.nano

Revision history for this message
Steve Langasek (vorlon) wrote :

51-rm-usr-share-parts.sh seems to largely be a recreation of chroot_local-hooks/04-purge-docs.sh from the alip config. Any reason not to use this same hook? (Sorry if you didn't know this was there!)

A few differences between the alip hook and this one that are probably worth discussing:

 - rm -rf ./usr/share/doc - this removes all the copyright files. I think we need to retain these for legal reasons?
 - /usr/share/X11, /usr/share/xul-ext - would it be possible instead to fix the seed to not pull in anything that creates these directories? (which packages install to them?)
 - /usr/share/locale - I recall that we discussed this but can't remember now why it was decided we need to keep the en locales instead of just letting people use the default C locale? (If only the C locale needs to be supported, we can just remove the locales package)
 - /usr/share/i18n/locales - good addition; I wonder why this wasn't already being done in the example I got from Martin Pitt. (I think we should add this to the alip hook also)
 - /usr/share/i18n/charmaps - seems kind of arbitrary. Why are you keeping the DOS and Mac codepages, for instance?
 - /etc/X11, /etc/firefox - again, what is putting stuff here as part of nano?

review: Needs Information

« Back to merge proposal