Merge lp:~tom-gall/linaro/fix-752843-live-helper.config.natty.nano into lp:~linaro-maintainers/linaro/live-helper.config.natty.nano
Proposed by
Tom Gall
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tom Gall | ||||
Approved revision: | 47 | ||||
Merge reported by: | Tom Gall | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~tom-gall/linaro/fix-752843-live-helper.config.natty.nano | ||||
Merge into: | lp:~linaro-maintainers/linaro/live-helper.config.natty.nano | ||||
Diff against target: |
187 lines (+131/-3) 6 files modified
binary_local-hooks/51-rm-usr-share-parts.sh (+105/-0) binary_local-hooks/52-rm-etc-parts.sh (+7/-0) binary_local-hooks/53-rm-var-lib-parts.sh (+15/-0) chroot (+1/-1) common (+1/-1) conf_create.sh (+2/-1) |
||||
To merge this branch: | bzr merge lp:~tom-gall/linaro/fix-752843-live-helper.config.natty.nano | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek (community) | Needs Information | ||
Review via email: mp+57382@code.launchpad.net |
Description of the change
add to binary_local-hooks 51-rm-usr-
set LH_APT_RECOMMENDS to false
in conf_create specifically add linaro-nano to package list
To post a comment you must log in.
51-rm-usr- share-parts. sh seems to largely be a recreation of chroot_ local-hooks/ 04-purge- docs.sh from the alip config. Any reason not to use this same hook? (Sorry if you didn't know this was there!)
A few differences between the alip hook and this one that are probably worth discussing:
- rm -rf ./usr/share/doc - this removes all the copyright files. I think we need to retain these for legal reasons? i18n/locales - good addition; I wonder why this wasn't already being done in the example I got from Martin Pitt. (I think we should add this to the alip hook also) i18n/charmaps - seems kind of arbitrary. Why are you keeping the DOS and Mac codepages, for instance?
- /usr/share/X11, /usr/share/xul-ext - would it be possible instead to fix the seed to not pull in anything that creates these directories? (which packages install to them?)
- /usr/share/locale - I recall that we discussed this but can't remember now why it was decided we need to keep the en locales instead of just letting people use the default C locale? (If only the C locale needs to be supported, we can just remove the locales package)
- /usr/share/
- /usr/share/
- /etc/X11, /etc/firefox - again, what is putting stuff here as part of nano?