Merge lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712 into lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 165
Merged at revision: 165
Proposed branch: lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src
Diff against target: 68 lines (+48/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch (+40/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Kubuntu Packagers Pending
Review via email: mp+213641@code.launchpad.net

Commit message

* debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch
    - Cherry-pick a fix to a bug affecting online accounts (LP: #1299712)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-03-25 11:50:39 +0000
+++ debian/changelog 2014-04-01 12:51:30 +0000
@@ -1,3 +1,10 @@
1qtbase-opensource-src (5.2.1+dfsg-1ubuntu11) trusty; urgency=medium
2
3 * debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch
4 - Cherry-pick a fix to a bug affecting online accounts (LP: #1299712)
5
6 -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Tue, 01 Apr 2014 12:41:00 +0000
7
1qtbase-opensource-src (5.2.1+dfsg-1ubuntu10) trusty; urgency=medium8qtbase-opensource-src (5.2.1+dfsg-1ubuntu10) trusty; urgency=medium
29
3 * Make qt5-qmake Multi-Arch: same since it moved from shipping files in10 * Make qt5-qmake Multi-Arch: same since it moved from shipping files in
411
=== added file 'debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch'
--- debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch 1970-01-01 00:00:00 +0000
+++ debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch 2014-04-01 12:51:30 +0000
@@ -0,0 +1,40 @@
1From fa5e611af1bc38ba1305fd1983f7560cbc4aa041 Mon Sep 17 00:00:00 2001
2From: Alberto Mardegan <alberto.mardegan@canonical.com>
3Date: Mon, 31 Mar 2014 15:25:44 +0300
4Subject: [PATCH] When looking up the window hierarchy, stop at foreign windows
5
6If the window being activated is an embedded window, the parent window
7will be a foreign window (usually not even belonging to the current
8process); we shouldn't attempt to focus it.
9
10Task-number: QTBUG-37984
11Change-Id: I2ea03a86b30bbc43cde643e18e0e1d020e5f2c84
12---
13 src/widgets/kernel/qapplication_qpa.cpp | 11 +++++++++--
14 1 file changed, 9 insertions(+), 2 deletions(-)
15
16diff --git a/src/widgets/kernel/qapplication_qpa.cpp b/src/widgets/kernel/qapplication_qpa.cpp
17index 2f6e8ac..5a4a459 100644
18--- a/src/widgets/kernel/qapplication_qpa.cpp
19+++ b/src/widgets/kernel/qapplication_qpa.cpp
20@@ -126,8 +126,15 @@ bool QApplicationPrivate::modalState()
21
22 QWidget *qt_tlw_for_window(QWindow *wnd)
23 {
24- while (wnd && !wnd->isTopLevel()) // QTBUG-32177, wnd might be a QQuickView embedded via window container.
25- wnd = wnd->parent();
26+ // QTBUG-32177, wnd might be a QQuickView embedded via window container.
27+ while (wnd && !wnd->isTopLevel()) {
28+ QWindow *parent = wnd->parent();
29+ // Don't end up in windows not belonging to this application
30+ if (parent && parent->type() != Qt::ForeignWindow)
31+ wnd = wnd->parent();
32+ else
33+ break;
34+ }
35 if (wnd)
36 foreach (QWidget *tlw, qApp->topLevelWidgets())
37 if (tlw->windowHandle() == wnd)
38--
391.9.0
40
041
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-03-18 06:00:39 +0000
+++ debian/patches/series 2014-04-01 12:51:30 +0000
@@ -28,3 +28,4 @@
28Fix-log_clusters-calculation-in-HarfBuzz-NG-code-pat.patch28Fix-log_clusters-calculation-in-HarfBuzz-NG-code-pat.patch
29Minor-optimization-for-QTextEngine-shapeText.patch29Minor-optimization-for-QTextEngine-shapeText.patch
30HarfBuzz-NG-Hide-characters-that-should-normally-be-.patch30HarfBuzz-NG-Hide-characters-that-should-normally-be-.patch
31When-looking-up-the-window-hierarchy-stop-at-foreign.patch

Subscribers

People subscribed via source and target branches