Merge lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712 into lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 165
Merged at revision: 165
Proposed branch: lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qtbase-opensource-src
Diff against target: 68 lines (+48/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch (+40/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/kubuntu-packaging/qtbase_cherrypick_lp1299712
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Kubuntu Packagers Pending
Review via email: mp+213641@code.launchpad.net

Commit message

* debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch
    - Cherry-pick a fix to a bug affecting online accounts (LP: #1299712)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-03-25 11:50:39 +0000
3+++ debian/changelog 2014-04-01 12:51:30 +0000
4@@ -1,3 +1,10 @@
5+qtbase-opensource-src (5.2.1+dfsg-1ubuntu11) trusty; urgency=medium
6+
7+ * debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch
8+ - Cherry-pick a fix to a bug affecting online accounts (LP: #1299712)
9+
10+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Tue, 01 Apr 2014 12:41:00 +0000
11+
12 qtbase-opensource-src (5.2.1+dfsg-1ubuntu10) trusty; urgency=medium
13
14 * Make qt5-qmake Multi-Arch: same since it moved from shipping files in
15
16=== added file 'debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch'
17--- debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/When-looking-up-the-window-hierarchy-stop-at-foreign.patch 2014-04-01 12:51:30 +0000
19@@ -0,0 +1,40 @@
20+From fa5e611af1bc38ba1305fd1983f7560cbc4aa041 Mon Sep 17 00:00:00 2001
21+From: Alberto Mardegan <alberto.mardegan@canonical.com>
22+Date: Mon, 31 Mar 2014 15:25:44 +0300
23+Subject: [PATCH] When looking up the window hierarchy, stop at foreign windows
24+
25+If the window being activated is an embedded window, the parent window
26+will be a foreign window (usually not even belonging to the current
27+process); we shouldn't attempt to focus it.
28+
29+Task-number: QTBUG-37984
30+Change-Id: I2ea03a86b30bbc43cde643e18e0e1d020e5f2c84
31+---
32+ src/widgets/kernel/qapplication_qpa.cpp | 11 +++++++++--
33+ 1 file changed, 9 insertions(+), 2 deletions(-)
34+
35+diff --git a/src/widgets/kernel/qapplication_qpa.cpp b/src/widgets/kernel/qapplication_qpa.cpp
36+index 2f6e8ac..5a4a459 100644
37+--- a/src/widgets/kernel/qapplication_qpa.cpp
38++++ b/src/widgets/kernel/qapplication_qpa.cpp
39+@@ -126,8 +126,15 @@ bool QApplicationPrivate::modalState()
40+
41+ QWidget *qt_tlw_for_window(QWindow *wnd)
42+ {
43+- while (wnd && !wnd->isTopLevel()) // QTBUG-32177, wnd might be a QQuickView embedded via window container.
44+- wnd = wnd->parent();
45++ // QTBUG-32177, wnd might be a QQuickView embedded via window container.
46++ while (wnd && !wnd->isTopLevel()) {
47++ QWindow *parent = wnd->parent();
48++ // Don't end up in windows not belonging to this application
49++ if (parent && parent->type() != Qt::ForeignWindow)
50++ wnd = wnd->parent();
51++ else
52++ break;
53++ }
54+ if (wnd)
55+ foreach (QWidget *tlw, qApp->topLevelWidgets())
56+ if (tlw->windowHandle() == wnd)
57+--
58+1.9.0
59+
60
61=== modified file 'debian/patches/series'
62--- debian/patches/series 2014-03-18 06:00:39 +0000
63+++ debian/patches/series 2014-04-01 12:51:30 +0000
64@@ -28,3 +28,4 @@
65 Fix-log_clusters-calculation-in-HarfBuzz-NG-code-pat.patch
66 Minor-optimization-for-QTextEngine-shapeText.patch
67 HarfBuzz-NG-Hide-characters-that-should-normally-be-.patch
68+When-looking-up-the-window-hierarchy-stop-at-foreign.patch

Subscribers

People subscribed via source and target branches