Looks fine to me. Having bools for those is fine, we could also have an int value (0=don't vibrate, 1=vibrate on ring, 2=vibrate on silence). Small wording comment inline as well
Setting as "approve" by comment but not changing the status, it would be nice if an english speaker could comment on the wording issue. Otherwise that looks good so feel free to ack it once that's sorted out
Looks fine to me. Having bools for those is fine, we could also have an int value (0=don't vibrate, 1=vibrate on ring, 2=vibrate on silence). Small wording comment inline as well
Setting as "approve" by comment but not changing the status, it would be nice if an english speaker could comment on the wording issue. Otherwise that looks good so feel free to ack it once that's sorted out