Merge lp:~tiagosh/gsettings-ubuntu-touch-schemas/add-call-messages-vibration-properties into lp:gsettings-ubuntu-touch-schemas

[Tiago Salem Herrmann]

Add support for vibration on incoming calls/messages.

Add support for vibration on incoming calls/messages.

[Sebastien Bacher (seb128)]

Looks fine to me. Having bools for those is fine, we could also have an int value (0=don't vibrate, 1=vibrate on ring, 2=vibrate on silence). Small wording comment inline as well

Setting as "approve" by comment but not changing the status, it would be nice if an english speaker could comment on the wording issue. Otherwise that looks good so feel free to ack it once that's sorted out

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:33
http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-ci/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-armhf-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gsettings-ubuntu-touch-schemas-ci/26/rebuild

review: Approve (continuous-integration)

[Iain Lane (laney)]

On Mon, Jul 07, 2014 at 07:52:20PM -0000, Tiago Salem Herrmann wrote:
> […]
> === modified file 'schemas/com.ubuntu.touch.sound.gschema.xml.in.in'

We should stop updating gsettings. That was only kept as an interim
while telephony-service was being transitioned. Could you please drop
this?

Whoever does the u-s-s code side of this can stop updating GSettings
there too.

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Lars Karlitski (larsu)]

> Looks fine to me. Having bools for those is fine, we could also have an int
> value (0=don't vibrate, 1=vibrate on ring, 2=vibrate on silence). Small
> wording comment inline as well

I prefer strings: it makes it easier to deal with when debugging or having a quick look.

However in this case I think the two booleans are better, because we allow all combinations of those (according to the spec). Representing all of them in a single enum would be a bit awkward.

[lp:~tiagosh/gsettings-ubuntu-touch-schemas/add-call-messages-vibration-properties]

34. By Tiago Salem Herrmann on 2014-07-08

drop gsettings schema

[Tiago Salem Herrmann (tiagosh)]

> Looks fine to me. Having bools for those is fine, we could also have an int
> value (0=don't vibrate, 1=vibrate on ring, 2=vibrate on silence). Small
> wording comment inline as well

I think this is also possible, but as Lars said, the booleans allow combinations and match the UI requirements: https://wiki.ubuntu.com/Sound#Settings
Also as reference, this is the telephony-service patch to use the proposed approach with booleans: https://code.launchpad.net/~tiagosh/telephony-service/vibrate-on-calls-and-messages/+merge/225886

>
> Setting as "approve" by comment but not changing the status, it would be nice
> if an english speaker could comment on the wording issue. Otherwise that looks
> good so feel free to ack it once that's sorted out

I think you are right, but as I was asked to drop the gsettings part, we don't need the descriptions anymore.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-ci/27/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-amd64-ci/7/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-armhf-ci/7
    FAILURE: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-i386-ci/7/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gsettings-ubuntu-touch-schemas-ci/27/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-ci/28/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-amd64-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-armhf-ci/8
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-i386-ci/8

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gsettings-ubuntu-touch-schemas-ci/28/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:34
http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-amd64-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-armhf-ci/9
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gsettings-ubuntu-touch-schemas-utopic-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gsettings-ubuntu-touch-schemas-ci/29/rebuild

review: Approve (continuous-integration)

[Sebastien Bacher (seb128)]

thanks

review: Approve

=== modified file 'accountsservice/com.ubuntu.touch.AccountsService.Sound.xml'
--- accountsservice/com.ubuntu.touch.AccountsService.Sound.xml	2014-03-04 20:12:42 +0000
+++ accountsservice/com.ubuntu.touch.AccountsService.Sound.xml	2014-07-08 01:29:15 +0000
@@ -18,5 +18,21 @@
                 value="/usr/share/sounds/ubuntu/notifications/Xylo.ogg"/>
         </property>
 
+        <property name="IncomingCallVibrate" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
+        </property>
+
+        <property name="IncomingCallVibrateSilentMode" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
+        </property>
+
+        <property name="IncomingMessageVibrate" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
+        </property>
+
+        <property name="IncomingMessageVibrateSilentMode" type="b" access="readwrite">
+            <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
+        </property>
+
     </interface>
 </node>