Merge ~tiago.pasqualini/charm-nagios:livestatus into charm-nagios:master
Proposed by
Tiago Pasqualini da Silva
Status: | Superseded | ||||
---|---|---|---|---|---|
Proposed branch: | ~tiago.pasqualini/charm-nagios:livestatus | ||||
Merge into: | charm-nagios:master | ||||
Diff against target: |
150 lines (+89/-0) 4 files modified
config.yaml (+19/-0) hooks/templates/livestatus.tmpl (+19/-0) hooks/upgrade_charm.py (+33/-0) tests/functional/test_config.py (+18/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Troup (community) | Needs Fixing | ||
Drew Freiberger (community) | Approve | ||
Xav Paice (community) | Needs Information | ||
Review via email: mp+392572@code.launchpad.net |
This proposal has been superseded by a proposal from 2021-05-21.
To post a comment you must log in.
I've left a few nit-picks in the comments, but specifically, this will require functional test coverage before it can be approved.
I would also suggest filing a bug to state the requirement and help us understand urgency of the need.
I can guess why it may be needed/useful for customers to be able to monitor livestatus externally, but we're not generally spending effort on new features in nagios as it's deprecated for focal.