Code review comment for ~tiago.pasqualini/charm-nagios:livestatus

Revision history for this message
Drew Freiberger (afreiberger) wrote :

I've left a few nit-picks in the comments, but specifically, this will require functional test coverage before it can be approved.

I would also suggest filing a bug to state the requirement and help us understand urgency of the need.

I can guess why it may be needed/useful for customers to be able to monitor livestatus externally, but we're not generally spending effort on new features in nagios as it's deprecated for focal.

review: Needs Fixing

« Back to merge proposal