Merge ~tiago.pasqualini/charm-nagios:livestatus into charm-nagios:master
Proposed by
Tiago Pasqualini da Silva
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | James Troup | ||||
Approved revision: | 12d8b6fa562226312dfed76721a4573211b4f618 | ||||
Merged at revision: | 841480d41d7ac8cb0aaaa8f1c35013094e8ae937 | ||||
Proposed branch: | ~tiago.pasqualini/charm-nagios:livestatus | ||||
Merge into: | charm-nagios:master | ||||
Diff against target: |
150 lines (+89/-0) 4 files modified
config.yaml (+19/-0) hooks/templates/livestatus.tmpl (+19/-0) hooks/upgrade_charm.py (+33/-0) tests/functional/test_config.py (+18/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
James Troup (community) | Approve | ||
Tom Haddon | Abstain | ||
BootStack Reviewers | Pending | ||
Xav Paice | Pending | ||
Drew Freiberger | Pending | ||
Review via email: mp+403157@code.launchpad.net |
This proposal supersedes a proposal from 2020-10-20.
Commit message
Added livestatus through xinetd
This patch adds the possibility to expose the livestatus socket to
the network by using xinetd. If enable_livestatus and
livestatus_
network.
Closes-bug: #1916530
To post a comment you must log in.
I've left a few nit-picks in the comments, but specifically, this will require functional test coverage before it can be approved.
I would also suggest filing a bug to state the requirement and help us understand urgency of the need.
I can guess why it may be needed/useful for customers to be able to monitor livestatus externally, but we're not generally spending effort on new features in nagios as it's deprecated for focal.