That looks good, thanks. Just a couple of nits:
+ a sensible default..
Just one dot will do.
+class TestLogDefaults(TestCaseForLogFormatter): + def test_default_log_level(self):
Can you add a docstring explaining the purpose of the test, maybe with a link to the bug, and then a blank line after it.
The assertions would be a little better as assertEquals.
« Back to merge proposal
That looks good, thanks. Just a couple of nits:
+ a sensible default..
Just one dot will do.
+class TestLogDefaults (TestCaseForLog Formatter) : log_level( self):
+ def test_default_
Can you add a docstring explaining the purpose of the test, maybe with a link to the bug, and then a blank line after it.
The assertions would be a little better as assertEquals.