Merge lp:~thomir-deactivatedaccount/bzr/fig-bug-747958 into lp:bzr
Proposed by
Thomi Richards
Status: | Merged |
---|---|
Approved by: | Martin Pool |
Approved revision: | no longer in the source branch. |
Merged at revision: | 6049 |
Proposed branch: | lp:~thomir-deactivatedaccount/bzr/fig-bug-747958 |
Merge into: | lp:bzr |
Diff against target: |
178 lines (+58/-16) 2 files modified
bzrlib/log.py (+19/-15) bzrlib/tests/test_log.py (+39/-1) |
To merge this branch: | bzr merge lp:~thomir-deactivatedaccount/bzr/fig-bug-747958 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thomi Richards (community) | Needs Resubmitting | ||
bzr-core | Pending | ||
Review via email: mp+69023@code.launchpad.net |
Commit message
Log levels are no longer reset to what the log formatter supports (bug 747958)
Description of the change
Fig bug #747958. Log levels are no longer overridden by what the log formatter supports if the user explicitly asked for a certain log level.
This is my second attempt at fixing this bug (my first was several months ago). There's now a unit test that reproduces the issue and passed with the new code.
To post a comment you must log in.
That looks good, thanks. Just a couple of nits:
+ a sensible default..
Just one dot will do.
+class TestLogDefaults (TestCaseForLog Formatter) : log_level( self):
+ def test_default_
Can you add a docstring explaining the purpose of the test, maybe with a link to the bug, and then a blank line after it.
The assertions would be a little better as assertEquals.