Code review comment for lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-queue-name

Revision history for this message
Celso Providelo (cprov) wrote :

Thanks Thomi,

It looks like cloud-service is already declaring a versioned queue name, so only workers need production update.

Rabbit it so amazing that it even survived to our silliness and fanout requests from the exchange to both queues (due to the same topic/routing-queue):

{{{
$ sudo rabbitmqctl list_queues name messages consumers
Listing queues ...
adt.requests.amd64.nova 0 1
adt.requests.amd64.nova.v1 10 0
adt.requests.i386.nova 0 1
adt.results.v1 0 1
...done.
}}}

We better drop the versioned queue otherwise the new worker will replay test request and there will be a conflict trying to re-create the swift container.

The unversioned queues should also be removed because the will never be used again.

review: Approve

« Back to merge proposal