Merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-queue-name into lp:adt-cloud-worker

Proposed by Thomi Richards
Status: Merged
Approved by: Thomi Richards
Approved revision: 26
Merged at revision: 26
Proposed branch: lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-queue-name
Merge into: lp:adt-cloud-worker
Diff against target: 12 lines (+1/-1)
1 file modified
adt_cloud_worker/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~thomir-deactivatedaccount/adt-cloud-worker/trunk-fix-queue-name
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+253450@code.launchpad.net

Commit message

Add API version to queue name.

Description of the change

Add API version to a-c-w queue name.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Thanks Thomi,

It looks like cloud-service is already declaring a versioned queue name, so only workers need production update.

Rabbit it so amazing that it even survived to our silliness and fanout requests from the exchange to both queues (due to the same topic/routing-queue):

{{{
$ sudo rabbitmqctl list_queues name messages consumers
Listing queues ...
adt.requests.amd64.nova 0 1
adt.requests.amd64.nova.v1 10 0
adt.requests.i386.nova 0 1
adt.results.v1 0 1
...done.
}}}

We better drop the versioned queue otherwise the new worker will replay test request and there will be a conflict trying to re-create the swift container.

The unversioned queues should also be removed because the will never be used again.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'adt_cloud_worker/__init__.py'
2--- adt_cloud_worker/__init__.py 2015-03-17 20:19:12 +0000
3+++ adt_cloud_worker/__init__.py 2015-03-18 23:55:39 +0000
4@@ -65,7 +65,7 @@
5 exchange = kombu.Exchange("adt.exchange", type="topic")
6 queues = [
7 kombu.Queue(
8- 'adt.requests.{}.nova'.format(arch),
9+ 'adt.requests.{}.nova.{}'.format(arch, API_VERSION),
10 exchange,
11 routing_key="{}.nova.{}".format(arch, API_VERSION)
12 )

Subscribers

People subscribed via source and target branches

to all changes: