Code review comment for lp:~therp-nl/web-addons/trunk-web-hide-buttons

Revision history for this message
Niels Huylebroeck (red15) wrote :

Just found something in default base addon:

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/addons/base/module/module_view.xml#L73

You can see they specify edit="0" and create="0"

Seems the handling of the arguments is done in the form view template on :
http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/xml/base.xml#L806

Perhaps we should not create duplicate functionality and more keywords...
I would still like to be able to avoid deletion via a view definition but it would be preferable to do it via a similar qweb / template inspired way i think.

review: Disapprove

« Back to merge proposal