Merge lp:~therp-nl/web-addons/trunk-web-hide-buttons into lp:~webaddons-core-editors/web-addons/6.1

[Ronald Portier (Therp)]

This merge adds a module to optionally hide the create and delete buttons from the web.

Wether one of the buttons is hidden or not depends on configuration of the context in the view action. So you can have most views with the buttons intact, and some views with the buttons readonly.

This is now limited to the Create and Delete buttons, but might in the future be extended to the duplicate and other buttons or UI elements al well.

[Stefan Rijnhart (Opener) (stefan-opener)]

Actually, the 'duplicate' button is hidden if 'nocreate' is defined in the context but it cannot be hidden separately.

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

LGTM

review: Approve

[Niels Huylebroeck (red15)]

Would be great if you could split the duplicate / create filters.

Something like

if (context.nocreate) {
    // Hide the create button
}
if (context.nocreate | context.noduplicate) {
    // Hide the duplicate button
}

[Niels Huylebroeck (red15)]

Just found something in default base addon:

http://bazaar.launchpad.net/~openerp/openobject-server/7.0/view/head:/openerp/addons/base/module/module_view.xml#L73

You can see they specify edit="0" and create="0"

Seems the handling of the arguments is done in the form view template on :
http://bazaar.launchpad.net/~openerp/openerp-web/7.0/view/head:/addons/web/static/src/xml/base.xml#L806

Perhaps we should not create duplicate functionality and more keywords...
I would still like to be able to avoid deletion via a view definition but it would be preferable to do it via a similar qweb / template inspired way i think.

review: Disapprove

[Alexandre Fayolle - camptocamp (alexandre-fayolle-c2c)]

> Just found something in default base addon:
>
> http://bazaar.launchpad.net/~openerp/openobject-
> server/7.0/view/head:/openerp/addons/base/module/module_view.xml#L73
>
> You can see they specify edit="0" and create="0"

note that the MP is targetted for 6.1. Are these available on that version?

[Holger Brunn (Therp) (hbrunn)]

no, this attributes were introduced in 7.0

review: Approve

[Stefan Rijnhart (Opener) (stefan-opener)]

Niels, I hope that your question has been answered by now. I'll give you a couple of days to react, otherwise I'll merge this proposal based on the two approves.

[Niels Huylebroeck (red15)]

Sorry for forgetting about this merge. Just ran into this while searching for the exact way to do it in v7.0.

Indeed it's not available for 6.1 but I wanted to suggest mainly to use the same words to avoid more migration work when moving from v6.1 to v7.0 but alas ... :)

review: Approve

=== added directory 'web_hide_buttons'
=== added file 'web_hide_buttons/AUTHORS'
--- web_hide_buttons/AUTHORS	1970-01-01 00:00:00 +0000
+++ web_hide_buttons/AUTHORS	2013-01-15 20:53:22 +0000
@@ -0,0 +1,3 @@
+Ronald Portier <[e-mail]>
+Stefan Rijnhart <[e-mail]>
+

=== added file 'web_hide_buttons/__init__.py'
=== added file 'web_hide_buttons/__openerp__.py'
--- web_hide_buttons/__openerp__.py	1970-01-01 00:00:00 +0000
+++ web_hide_buttons/__openerp__.py	2013-01-15 20:53:22 +0000
@@ -0,0 +1,43 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#    
+#    Copyright (C) 2013 Therp B.V. (<http://www.therp.nl>)
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as published
+#    by the Free Software Foundation, either version 3 of the License, or
+#    (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{
+    'name': 'web hide buttons',
+    'application': False,
+    'version': '6.1.r003',
+    'category': 'Web',
+    'description': '''
+This module makes it possible to hide Create and Delete buttons from the
+user, if requested through the context of the action defining the window.
+To hide both buttons add the following element to the xml for the
+ir.actions.act_window:
+<field name="context">{'nodelete': '1', 'nocreate': '1'}</field>
+''',
+    'author': 'Therp B.V.',
+    'website': 'http://www.therp.nl',
+    'license': 'AGPLv3',
+    'depends': [
+        'web',
+    ],
+    'init_xml': [],
+    'update_xml': [],
+    'demo_xml': [],
+    'installable': True,
+    'js': ['static/src/js/web_hide_buttons.js'],
+    }

=== added directory 'web_hide_buttons/static'
=== added directory 'web_hide_buttons/static/src'
=== added directory 'web_hide_buttons/static/src/js'
=== added file 'web_hide_buttons/static/src/js/web_hide_buttons.js'
--- web_hide_buttons/static/src/js/web_hide_buttons.js	1970-01-01 00:00:00 +0000
+++ web_hide_buttons/static/src/js/web_hide_buttons.js	2013-01-15 20:53:22 +0000
@@ -0,0 +1,57 @@
+/* -----------------------------------------------------------\ 
+ * web functions for web_hide_buttons
+ * --------------------------------------------------------- */
+
+/* comments to control jslint */
+/*jslint nomen: true, white: true, */
+/*global window, openerp, $, _ */
+
+openerp.web_hide_buttons = function (openerp) {
+    'use strict';
+
+    /** Change ListView to not show Create and Delete buttons when that
+    has been requested through the context passed from the action.
+    */
+    openerp.web.ListView.include({
+
+        on_loaded : function (record) {
+            var result, context;
+            result = this._super.apply(this, arguments);
+            if (this.groups.datagroup.context) {
+                context = this.groups.datagroup.context;
+                if (context.nocreate) {
+                    this.$element.find('.oe-list-add')
+                        .attr('disabled', true).hide();
+                }
+                if (context.nodelete) {
+                    this.$element.find('.oe-list-delete')
+                        .attr('disabled', true).hide();
+                }
+            }
+            return result;
+        }
+    });
+
+    openerp.web.FormView.include({
+
+        on_loaded : function (record) {
+            var result, context;
+            result = this._super.apply(this, arguments);
+            context = this.dataset.get_context();
+            if (context) {
+                if (context.nocreate) {
+                    this.$element.find('.oe_form_button_create')
+                        .attr('disabled', true).hide();
+                    this.$element.find('.oe_form_button_duplicate')
+                        .attr('disabled', true).hide();
+                }
+                if (context.nodelete) {
+                    this.$element.find('.oe_form_button_delete')
+                        .attr('disabled', true).hide();
+                }
+            }
+            return result;
+        }
+    });
+
+};