Code review comment for lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

10ff: You need to check if this option exists (has_option) before accessing it, as also SafeConfigParser raises ConfigParser.NoOptionError on nonexisting options. Then you can remove 12f

Could you explain why you do the extra checks and unset PGPASSWORD? The environment you change will die with the script process, and the only other processes who see it are the openupgrade servers it starts, or am I mistaken?

review: Needs Fixing (code review)

« Back to merge proposal