Merge lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password into lp:openupgrade-server
Proposed by
Ronald Portier (Therp)
Status: | Merged |
---|---|
Merged at revision: | 4644 |
Proposed branch: | lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password |
Merge into: | lp:openupgrade-server |
Diff against target: |
74 lines (+38/-8) 1 file modified
scripts/migrate.py (+38/-8) |
To merge this branch: | bzr merge lp:~therp-nl/openupgrade-server/7.0_lp1265463_use_password |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Holger Brunn (Therp) | code review | Approve | |
Stefan Rijnhart (Opener) | Needs Information | ||
Ronald Portier (Therp) | Needs Resubmitting | ||
Review via email:
|
Description of the change
Migrate script will use all database connection info found in the config file that is already a required parameter.
To post a comment you must log in.
10ff: You need to check if this option exists (has_option) before accessing it, as also SafeConfigParser raises ConfigParser. NoOptionError on nonexisting options. Then you can remove 12f
Could you explain why you do the extra checks and unset PGPASSWORD? The environment you change will die with the script process, and the only other processes who see it are the openupgrade servers it starts, or am I mistaken?