Merge lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name into lp:banking-addons/6.1

[Stefan Rijnhart (Opener)]

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

One typo which was already there but can be corrected in the same time: s/More then/More than/

Otherwise it seems good to me, if we consider that we have to take the first partner found when more than one is found.
Maybe it deserves a comment in the docstring as it may be misleading?

Though, you can merge as is.

review: Approve

[lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name]

142. By Stefan Rijnhart (Opener) on 2012-12-05

[FIX] Typo and docstring

[Stefan Rijnhart (Opener) (stefan-opener)]

Thanks for the review! I followed up your suggestions.

review: Needs Resubmitting

=== modified file 'account_banking/wizard/banktools.py'
--- account_banking/wizard/banktools.py	2012-06-26 11:17:32 +0000
+++ account_banking/wizard/banktools.py	2012-12-05 07:24:20 +0000
@@ -125,6 +125,9 @@
                           country_code, log):
     '''
     Get or create the partner belonging to the account holders name <name>
+
+    If multiple partners are found with the same name, select the first and
+    add a warning to the import log.
     '''
     partner_obj = pool.get('res.partner')
     partner_ids = partner_obj.search(cursor, uid, [('name', 'ilike', name)])
@@ -177,13 +180,12 @@
                 'country_id': country_id,
             })],
         ))
-    elif len(partner_ids) > 1:
-        log.append(
-            _('More then one possible match found for partner with name %(name)s')
-            % {'name': name}
-        )
-        return False
     else:
+        if len(partner_ids) > 1:
+            log.append(
+                _('More than one possible match found for partner with name %(name)s')
+                % {'name': name}
+                )
         partner_id = partner_ids[0]
     return partner_id