Code review comment for lp:~therp-nl/banking-addons/ab6.1-lp1085113-take_first_of_two_partners_with_same_name
Revision history for this message
| Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote | # |
review:
Approve
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
One typo which was already there but can be corrected in the same time: s/More then/More than/
Otherwise it seems good to me, if we consider that we have to take the first partner found when more than one is found.
Maybe it deserves a comment in the docstring as it may be misleading?
Though, you can merge as is.