Code review comment for lp:~termie/nova/remove_ioloop

Revision history for this message
Joshua McKenty (joshua-mckenty) wrote :

lgtm, with a bit of either hesitation or confusion about how you're storing originalAttach as an instance property (in _monkeyPatchAttach). Isn't there some risk that rpc.Consumer.attach_to_twisted will be called independently from some of the code during the test runs? (I suppose it's very unlikely...)

review: Approve

« Back to merge proposal