lp:~termie/nova/remove_ioloop

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~hudson-openstack/nova/trunk at revision 300

Joshua McKenty (community): Approve on 2010-09-20

Diff: 265 lines (+64/-34)

7 files modified

nova/rpc.py (+2/-17)
nova/test.py (+49/-5)
nova/tests/access_unittest.py (+1/-1)
nova/tests/auth_unittest.py (+1/-1)
nova/tests/cloud_unittest.py (+8/-6)
nova/tests/objectstore_unittest.py (+1/-1)
nova/tests/rpc_unittest.py (+2/-3)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

273. By termie on 2010-09-08

Tests turn things into inlineCallbacks.

This is to duplicate the old behavior of BaseTestCase and to generally
prevent the bad situation in that tests appear to be passing when in
fact they haven't run because @defer.inlineCallbacks was forgotten.

272. By termie on 2010-09-08

Missed an instance of attach_to_tornado.

Kind of crappy because testing didn't catch it, the test code certainly
appears to be testing those features, however.

271. By termie on 2010-09-08

Remove tornado-related code from almost everything.

Left it in api where it is still being used pending gundlach's changes.

270. By Soren Hansen on 2010-09-08

It's annoying and confusing to have to set PYTHONPATH to point to your
development tree before you run any of the scripts.

If you're lucky, it just fails (because you don't have nova in the default
search path (i.e. don't have them installed in /usr/lib/blah)) so that you can
fix it up.

If you're less lucky, you spend at least a couple of minutes wondering
why the cool changes you made to one of the nova modules don't take effect
until you realise it's because it's using the nova stuff in /usr/lib.

So, to save myself (and probably others) a bit of time, this patch adds
a snippet to each of the scripts in bin/ to detect this and set up the PYTHONPATH.

269. By Soren Hansen on 2010-09-03

Just a couple of UML-only fixes:
 * Due to an issue with libvirt, we need to chown the disk image to root.
 * Just point UML's console directly at a file, and don't bother with the pty. It was only used for debugging.

268. By Michael Gundlach on 2010-09-02

Replace an if/else with a dict lookup to a factory method.

267. By Soren Hansen on 2010-09-01

Create console.log ahead of time. This ensures that the user running nova-compute maintains read privileges.

266. By Soren Hansen on 2010-09-01

This improves the changelog generated as part of "setup.py sdist". If you look at it now, it says that Tarmac has done everything and every little commit is listed. With this patch, it only logs the "top-most" commit and credits the author rather than the committer.

Example from the current output format (from current trunk):
##########################################
2010-08-31 Tarmac

        Adjust setup.py to match nova-rsapi -> nova-api-new rename.

2010-08-31 Soren Hansen <email address hidden>

        Fix up setup.py to match nova-rsapi -> nova-api-new rename.

2010-08-30 Tarmac

        Reconnect to libvirt on broken connection.

2010-08-30 Soren Hansen <email address hidden>

        Detect if libvirt connection has been broken and reestablish it.

2010-08-30 Tarmac

        pylint fixes for /nova/virt/connection.py

2010-08-30 <email address hidden>

        Merge trunk and resolve conflicts

##########################################

With this patch, this is reduced to:

##########################################
2010-08-31 Soren Hansen <email address hidden>

        Adjust setup.py to match nova-rsapi -> nova-api-new rename.

2010-08-30 Soren Hansen <email address hidden>

        Reconnect to libvirt on broken connection.

2010-08-30 <email address hidden>

        pylint fixes for /nova/virt/connection.py

##########################################

265. By Matt Dietz on 2010-09-01

Moved API tests into a sub-folder of the tests/ and added a stubbed-out test declarations to mirror existing API tickets.

Resubmission from earlier because of my improper file move.

264. By Soren Hansen on 2010-08-31

Call getInfo() instead of getVersion() on the libvirt connection object. virConnectGetVersion was not exposed properly in the python bindings until quite recently, so this makes us rather more backwards compatible.