Code review comment for lp:~terceiro/lava-dispatcher/master-device-version

Andy Doan <email address hidden> writes:

> On 12/06/2012 04:58 PM, Michael Hudson-Doyle wrote:
>> It looks ok to me, but the part that concerns me is the point at which
>> it is called -- get_device_version will only work usefully if the board
>> is in the master image, but I don't think its guaranteed to be at this
>> point. I would rather have the target squirrel the device version away
>> the first time the device boots into the master image, if that's
>> possible.
>
> Read again - I thought the same thing the first time I read the code. It
> actually sets this the first time it boots to master and is safe to call
> from any context afterwards.

Ah quite right. +1 to merge.

Cheers,
mwh