Merge lp:~terceiro/lava-dispatcher/master-device-version into lp:lava-dispatcher
Proposed by
Antonio Terceiro
Status: | Merged |
---|---|
Merged at revision: | 490 |
Proposed branch: | lp:~terceiro/lava-dispatcher/master-device-version |
Merge into: | lp:lava-dispatcher |
Diff against target: |
80 lines (+30/-1) 2 files modified
lava_dispatcher/device/master.py (+26/-0) lava_dispatcher/job.py (+4/-1) |
To merge this branch: | bzr merge lp:~terceiro/lava-dispatcher/master-device-version |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Linaro Validation Team | Pending | ||
Review via email: mp+138463@code.launchpad.net |
Description of the change
this branch adds support for obtaining the version (hwpack/rootfs) for master images.
To post a comment you must log in.
On 12/06/2012 08:21 AM, Antonio Terceiro wrote: r/job.py' /job.py 2012-11-24 20:58:07 +0000 /job.py 2012-12-06 14:20:27 +0000 device_ version' : self.context. get_device_ version( ), test_data. job_status = 'fail' test_data. add_metadata( { 'target. device_ version' : self.context. get_device_ version( ) or 'error'})
> === modified file 'lava_dispatche
> --- lava_dispatcher
> +++ lava_dispatcher
> @@ -148,7 +148,6 @@
>
> metadata = {
> 'target.hostname': self.target,
> - 'target.
> }
>
> if 'device_type' in self.job_data:
> @@ -232,6 +231,7 @@
> self.context.
> raise
> finally:
> + self.context.
Is the get_device_version sufficiently exception-safe? ie - the 3 lines
of code after this are important or the lava-results won't get submitted
properly. I'm not the best at proper error handling, maybe Michael can
speculate. Also - this wraps way past column 80 and is going to make
pylint/pflakes/etc complain.
> if submit_results: results. get('parameters ', {}) submit_ results[ 'command' ]](
> params = submit_
> action = lava_commands[