Code review comment for lp:~terceiro/lava-dispatcher/bootloadertype

On Tue, Sep 03, 2013 at 11:53:24PM -0000, Tyler Baker wrote:
> Review: Approve
>
> Approved. I grepped through the tip, looks to me you have renamed all
> occurances. Thanks for enabling the prebuilt images!
>
> I'm curious if you have tested UEFI booting with a prebuilt image with
> these changes?

I did, that was actually my initial motivation - having to wait for
l-m-c every time was killing me. ;-)

> I suggest we add a functional test cases for UEFI / AXF booting with a
> prebuilt image.

Agreed. Can you please create one based on

http://community.validation.linaro.org/images/armv7-fastmodel/hwpack_linaro-vexpress_20130811-427_armhf_supported.tar.gz
http://community.validation.linaro.org/images/armv7-fastmodel/linaro-raring-nano-lava-20130811-459.tar.gz

and let me know?

I already did the renaming from bootloader to bootloadertype in the repository.

> The only CI job I'm aware of that uses the old "bootloader" parameter
> is:
> http://validation.linaro.org/dashboard/image-reports/linux-efi-stub
>
> When we deploy to production, we need to communicate this change to Fathi at that time.

I'm talking to him on IRC about it.