Merge lp:~terceiro/lava-dispatcher/bootloadertype into lp:lava-dispatcher
Status: | Merged |
---|---|
Merged at revision: | 666 |
Proposed branch: | lp:~terceiro/lava-dispatcher/bootloadertype |
Merge into: | lp:lava-dispatcher |
Diff against target: |
256 lines (+33/-32) 9 files modified
lava_dispatcher/actions/deploy.py (+3/-3) lava_dispatcher/client/targetdevice.py (+3/-3) lava_dispatcher/device/bootloader.py (+4/-4) lava_dispatcher/device/fastmodel.py (+10/-9) lava_dispatcher/device/ipmi_pxe.py (+3/-3) lava_dispatcher/device/master.py (+3/-3) lava_dispatcher/device/qemu.py (+3/-3) lava_dispatcher/device/sdmux.py (+2/-2) lava_dispatcher/device/target.py (+2/-2) |
To merge this branch: | bzr merge lp:~terceiro/lava-dispatcher/bootloadertype |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Tyler Baker | Approve | ||
Linaro Validation Team | Pending | ||
Review via email: mp+183291@code.launchpad.net |
Description of the change
This patch makes two changes:
- first, it addds a bootloadertype argument to the
deploy_
which bootloader is present in the image. This makes it possible for
example to interact with uefi when using a prebuilt image, what
previosly was only possible with hwpack+rootfs (for prebuilt image
u-boot was always assumed)
- second, the "bootloader" argument is being renamed to
"bootloader
The `bootloader` device uses a "bootloader" argument that actually
means the bootloader, i.e. you are supposed to pass the URL of a
bootloader binary to it.
Approved. I grepped through the tip, looks to me you have renamed all occurances. Thanks for enabling the prebuilt images!
I'm curious if you have tested UEFI booting with a prebuilt image with these changes? I suggest we add a functional test cases for UEFI / AXF booting with a prebuilt image.
The only CI job I'm aware of that uses the old "bootloader" parameter is: http:// validation. linaro. org/dashboard/ image-reports/ linux-efi- stub
When we deploy to production, we need to communicate this change to Fathi at that time.