Code review comment for lp:~terceiro/lava-dispatcher/bootloadertype

Revision history for this message
Tyler Baker (tyler-baker) wrote :

Approved. I grepped through the tip, looks to me you have renamed all occurances. Thanks for enabling the prebuilt images!

I'm curious if you have tested UEFI booting with a prebuilt image with these changes? I suggest we add a functional test cases for UEFI / AXF booting with a prebuilt image.

The only CI job I'm aware of that uses the old "bootloader" parameter is: http://validation.linaro.org/dashboard/image-reports/linux-efi-stub

When we deploy to production, we need to communicate this change to Fathi at that time.

review: Approve

« Back to merge proposal