Merge lp:~teknico/charms/precise/juju-gui/1172190-non-legacy-node-ppa into lp:~juju-gui/charms/precise/juju-gui/trunk

[Nicola Larosa]

Convert charm back to using non-legacy node ppa

With reference to https://launchpad.net/~chris-lea/+ppa-packages .

The only behavioral change is in the third chunk of hooks/utils.py ,
the rest is just code reformatting to appease Sublime Text, and some
additional docstrings.

https://codereview.appspot.com/8837048/

[Nicola Larosa (teknico)]

Reviewers: mp+160608_code.launchpad.net,

Message:
Please take a look.

Description:
Convert charm back to using non-legacy node ppa

With reference to https://launchpad.net/~chris-lea/+ppa-packages .

The only behavioral change is in the third chunk of hooks/utils.py ,
the rest is just code reformatting to appease Sublime Text, and some
additional docstrings.

https://code.launchpad.net/~teknico/charms/precise/juju-gui/1172190-non-legacy-node-ppa/+merge/160608

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/8837048/

Affected files:
   A [revision details]
   M hooks/backend.py
   M hooks/bootstrap_utils.py
   M hooks/install
   M hooks/utils.py
   M tests/test_backends.py

[Francesco Banconi (frankban)]

LGTM Nicola, thank you.
Your Lint/PEP8 clean up is very appreciated!

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py
File hooks/backend.py (right):

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py#newcode4
hooks/backend.py:4: Backends implement start(), stop() and install()
methods. A backend is composed
Thanks for adding documentation on the backend framework.

https://codereview.appspot.com/8837048/

[Gary Poster (gary)]

LGTM with comment fix.

Thank you!

Gary

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py
File hooks/backend.py (right):

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py#newcode4
hooks/backend.py:4: Backends implement start(), stop() and install()
methods. A backend is composed
On 2013/04/24 11:49:15, frankban wrote:
> Thanks for adding documentation on the backend framework.

Yes, excellent.

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py#newcode13
hooks/backend.py:13: # If we are unable to use external code due to some
deployment restrictions,
This isn't quite right. The flag we have prevents additional
repositories from being installed. We will still attempt to install the
packages, and will fail early if they are unavailable. The expectation
is that, if you don't install the additional repositories, you will need
to have the packages available in the image's/system's existing
repositories. That's how IS does it, though we want to improve the
details of that approach in the future (see
http://bazaar.launchpad.net/~mew/charms/precise/juju-gui/sandbox-charm/revision/58
for a hint of how they do it now).

https://codereview.appspot.com/8837048/

[Nicola Larosa (teknico)]

Thanks for the reviews, frankban and gary.poster.

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py
File hooks/backend.py (right):

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py#newcode4
hooks/backend.py:4: Backends implement start(), stop() and install()
methods. A backend is composed
> frankban wrote:
>> Thanks for adding documentation on the backend framework.

gary.poster wrote:
> Yes, excellent.

Well, I just stol... ehm, repurposed bcsaller's branch description. :-)

https://codereview.appspot.com/8837048/diff/1/hooks/backend.py#newcode13
hooks/backend.py:13: # If we are unable to use external code due to some
deployment restrictions,
gary.poster wrote:
> This isn't quite right. [snip]

So, IIUC, we can expect the packages to be installed, one way or
another, and this comment is incorrect, so I'm removing it.

https://codereview.appspot.com/8837048/

[lp:~teknico/charms/precise/juju-gui/1172190-non-legacy-node-ppa]

48. By Nicola Larosa on 2013-04-24

Comment removed as per review.

[Nicola Larosa (teknico)]

*** Submitted:

Convert charm back to using non-legacy node ppa

With reference to https://launchpad.net/~chris-lea/+ppa-packages .

The only behavioral change is in the third chunk of hooks/utils.py ,
the rest is just code reformatting to appease Sublime Text, and some
additional docstrings.

R=frankban, gary.poster
CC=
https://codereview.appspot.com/8837048

https://codereview.appspot.com/8837048/