lp:~juju-gui/charms/precise/juju-gui/trunk

Created by Benji York on 2012-11-14 and last modified on 2014-04-18
Get this branch:
bzr branch lp:~juju-gui/charms/precise/juju-gui/trunk
Members of Juju GUI Hackers can upload to this branch. Log in for directions.

Branch merges

Related bugs

Related blueprints

Branch information

Owner:
Juju GUI Hackers
Review team:
charmers
Status:
Mature

Recent revisions

182. By Francesco Banconi on 2014-04-18

Avoid clickjacking.

Update the builtin and legacy servers to send
the proper X-Frame-Options header so that
iframing is denied from extraneous origins.

The legacy server has been update to ensure
clickjacking is not possible on jujucharms.com.

Tests: `make unittest`.

QA:
- juju bootstrap an environment;
- run `make deploy`;
- wait for the GUI to be ready/started;
- open the GUI with the browser and log in;
- prepare an HTML page like the following, replacing
  <GUI UNIT HOSTNAME> with the address of the GUI in
  your environment:

<!DOCTYPE html>
<html>
<head>
    <title>test clickjacking</title>
</head>
<body>
<iframe src="https://<GUI UNIT HOSTNAME>"
  height="800" width="1000"></iframe>
</body>
</html>

- open the test page above with the browser,
  the iframe should be empty;
- switch to the legacy server:
  `juju set juju-gui builtin-server=false`;
- wait a minute for the config-changed hook
  to complete;
- open the test page above with the browser,
  the iframe should be empty;
- destroy the environment.

R=jeff.pihach
CC=
https://codereview.appspot.com/88090048

181. By Francesco Banconi on 2014-04-16

Merged back the new charm release.

180. By Francesco Banconi on 2014-04-15

Merged changes from the released charm.

179. By Francesco Banconi on 2014-04-15

Trusty charm.

Make the charm work on trusty.
Also update the charm documentation.

QA:
Please run the unit and functional tests
using both precise and trusty.
Follow the instructions in the HACKING file.

R=bac
CC=
https://codereview.appspot.com/88100044

178. By Richard Harding on 2014-04-09

Merged back the new charm release.

177. By Richard Harding on 2014-04-09

Updated to the newest juju-gui release.

176. By Francesco Banconi on 2014-04-09

Make the GUI server redirect to the default icon.

Create a specialized proxy handler for handling
Juju HTTP API requests. In this subclass, handle
the case a request is for a local charm icon
that cannot be found on the Juju server.

Tests: `make unittest`.

QA:
- `juju bootstrap`;
- from the branch root, run `make deploy`;
- wait for the GUI service to be ready;
- switch to the trunk branch:
  `juju set juju-gui juju-gui-source=develop`
- wait for the GUI to be ready;
- deploy local charms including an icon:
  you should see the icons are correctly displayed in the
  service blocks and inspector header;
- deploy a local charm not including an icon:
  you should see the fallback icon displayed both in
  the service block and the inspector;
- destroy the environment, done.

R=bac
CC=
https://codereview.appspot.com/86100043

175. By Benji York on 2014-03-19

Handle broken nrpe relations.

R=frankban
CC=
https://codereview.appspot.com/76860047

174. By Francesco Banconi on 2014-03-17

Update juju-deployer and python-jujuclient.

Update GUI server/juju requirements to the newest version.

QA:
- bootstrap a juju-core trunk env;
- make deploy;
- open the GUI, ensure the GUI server works well by:
  - using the GUI as usual (deploy a charm, change settings, etc.);
  - deploying a bundle from the GUI;
  - deploying a local charm from the GUI;
  - going to /gui-server-info and checking everything seems fine.
- destroy the environment, thank you!

R=matthew.scott
CC=
https://codereview.appspot.com/75190044

173. By Richard Harding on 2014-03-13

Merged back the new charm release.

Branch metadata

Branch format:
Branch format 7
Repository format:
Bazaar repository format 2a (needs bzr 1.16 or later)
This branch contains Public information 
Everyone can see this information.

Subscribers