Code review comment for lp:~ted/snapcraft/aws-iot

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

This looks really good but the need for AWSCLIPlugin I want to avoid.

I still strongly believe that the AWSCLIPlugin should not be needed and a build-package for awscli should be used (we can update the deb in our ppa so we have the IOT option if need be).

Or is there a reason for the aws cli to live in the snap?

There are also some inline comments.

ftr,
$ rmadison awscli
 awscli | 1.2.9-2 | trusty/universe | source, all
 awscli | 1.7.0-1 | vivid/universe | source, all
 awscli | 1.7.0-1build1 | wily/universe | source, all
 awscli | 1.7.0-1build1 | xenial/universe | source, all

review: Needs Fixing

« Back to merge proposal