Author: Sergio Schvezov
Author Date: 2021-06-18 17:16:58 UTC

Merge pull request #3539 from snapcore/whoami-schema

store: whoami schema fix

Author: dependabot[bot]
Author Date: 2021-06-17 15:10:47 UTC

build(deps): bump pyyaml from 5.3 to 5.4

Bumps [pyyaml](https://github.com/yaml/pyyaml) from 5.3 to 5.4.
- [Release notes](https://github.com/yaml/pyyaml/releases)
- [Changelog](https://github.com/yaml/pyyaml/blob/master/CHANGES)
- [Commits](https://github.com/yaml/pyyaml/compare/5.3...5.4)

Signed-off-by: dependabot[bot] <support@github.com>

Author: Chris Patterson
Author Date: 2021-05-04 15:45:10 UTC

yaml: ignore errors from malformed input when checking for duplicates

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2021-04-27 21:14:34 UTC

elf: add fallback methods to detect library dependencies (#3514)

libc6 may mismatch with the paths provided to ldd in LD_LIBRARY_PATH.

This may be avoided if invoking the binary directory and using
LD_TRACE_LOADED_OBJECTS, but this method is limited to executable
files.

This updates the library dependency search to try three variants:
(1) use ldd as today. if ldd fails..
(2) use ldd with LD_PRELOAD to specify libc6 from host. if ldd fails...
(3) use ld trace method. if ldd trace fails...
(4) warn as before.

For #2, libc6 is expected as /lib/<arch-triplet>/libc.so.6. This likely
will need to be more robust in the future.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Sergio Schvezov
Author Date: 2021-04-07 01:33:34 UTC

cli: rename experimental login environment variable

It was SNAPCRAFT_LOGIN, which conflicted with commonly named
environment variables used for CI/CD.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Author: Sergio Schvezov
Author Date: 2021-04-06 14:12:06 UTC

Merge branch 'master' into spread-cryptography

Author: Chris Patterson
Author Date: 2021-03-10 15:25:38 UTC

store: improve platform detection (#3465)

Also add support for Windows and Darwin.

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Author: Sergio Schvezov
Author Date: 2021-03-09 16:20:52 UTC

Merge branch 'master' into py3.8

Author: Sergio Schvezov
Author Date: 2021-01-13 19:05:58 UTC

Merge branch 'master' into bp-apt-arch

Author: Chris Patterson
Author Date: 2021-01-13 17:14:07 UTC

cli: enable SNAPCRAFT_TARGET_ARCH envvar matching --target-arch

But ensure it is scrubbed from build provider flags so
that it doesn't get passed into target environment.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Sergio Schvezov
Author Date: 2020-11-09 15:23:05 UTC

review updates

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Author: Chris Patterson
Author Date: 2020-09-17 19:40:24 UTC

build providers: unified provider refactoring for provider setup

Refactoring for unified approach to checking if a provider is ready, and
performing installation.

- Adds 'is_provider_ready()' interface, replacing 'ensure_provider()'.

- Makes 'setup_provider()' responsible for all user interaction to install
and/or configure the provider, and its depdenencies. Adds 'interactive'
parameter to allow for non-interactive installs, though not currently utilized.

- Refactored LXD checks into their own methods, adding a compatibility check to
check the LXD version is 4.0+, and removing the snap install check in favor of
just ensuring the hardcoded /snap/bin/lx[cd] paths are present.

- Moves setup code out of MultipassCommand into the Multipass provider.

- Update lifecycle CLI to utilize new interfaces. When tty is not connected,
and setup is required, exit with error that that build provider is not
installed or configured.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-08-25 14:58:31 UTC

colcon v2 plugin: don't strip env for stage-runtime-dependencies

HTTP proxy settings are being lost.

- Remove the `-i` argument to `env`, there are no longer variables
  that must be filtered, allow all of the build-time environment
  variables through. This will include http(s)_proxy once the
  run scripts include it (shipped separately).

- Remove parameters to `stage-runtime-dependencies` which can just
  be picked up from the environment now, after removing `-i` from
  `env`.

- Remove PATH from env list as it no longer needs to be passed
  through explicitly, it is in the run script.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-08-14 11:31:55 UTC

specifications: fix typo in package-repositories

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-08-13 15:59:02 UTC

spread tests: fix classic patchelf linker regex to match all arches

ppc64el and others may not follow the `ld-linux` convention, e.g.:
/snap/core18/current/lib64/ld64.so.2

Fix by broadening the match to ld.*.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-07-20 15:05:39 UTC

sentry: don't report tool missing errors

Spread tests should capture any missing tools from the snap,
should we make that mistake. If the host is missing the tool,
do not offer to report it to sentry.

Fixes SNAPCRAFT-1V7

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-06-26 02:07:12 UTC

edge -> stable build snap

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Sergio Schvezov
Author Date: 2020-03-04 15:22:14 UTC

initial commit

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Author: Chris Patterson
Author Date: 2020-02-12 17:32:33 UTC

remote-build: introduce --launchpad-snapcraft-channel option

It may be useful to configure Launchpad to use a specific
snapcraft channel. This commit changes the default from "edge"
to "stable", and allows the user to configure it.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Chris Patterson
Author Date: 2020-01-10 21:51:42 UTC

plugin handler: split debug information if --split-debug passed

EXPERIMENTAL option to split debug information. Splits debug
information during PRIME step.

Stripped symbols are written to ./debug directory. Note that this
may cause an issue for projects being build in destructive mode that
already have a directory "debug" in the project tree.

Based off of James Henstridge's work available at:
https://github.com/snapcore/snapcraft/pull/2239

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

Author: Sergio Schvezov
Author Date: 2020-02-04 21:01:43 UTC

use a generator for any

Author: Sergio Schvezov
Author Date: 2020-01-26 06:36:41 UTC

meta: always generate snapcraft-runner to workaround classic (#2889) (#2891)

Snapcraft previously generated wrappers for most commands. Once
snapcraft became more conserative about generating unnecessary wrappers,
issues began to surface with regard to PATH being set incorrectly
for classic snap apps that did not use shell.

To work around the issue, this commit adds an empty snapcraft-runner to
the command-chain for all apps, where they typically would have none.
Once this issue is resolved in snapd, we can probably remove this
workaround.

Add unit tests for snapcraft-runner generation

Add some additional parameters to the SnapcraftYaml fixture
to make it more configurable.

LP: #1860369

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Chris Patterson <cjp256@gmail.com>