View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/snapcraft

Snapcraft has 8 active reviews.

Branches

Name Last Modified Last Commit
snapcraftctl-empty 2020-10-22 00:17:36 UTC 4 hours ago
snapcraftctl: add checks for empty string for set-version & set-grade

Author: Chris Patterson
Author Date: 2020-10-20 16:35:51 UTC

snapcraftctl: add checks for empty string for set-version & set-grade

It's a pretty common mistake for scriplets to end up setting "" in
set-version, leading the the following error:
`Failed to generate snap metadata: 'adopt-info' refers to part <part>,
but that part is lacking the 'parse-info' property.`

Setting an empty grade effectively just ignores the invalid value,
relying on the default grade later. Check this for "stable" or
"devel".

Explicitly error out with helpful messages when invalid options
are used.

- Add unit tests for coverage.

- Update related tests that set invalid grades.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

master 2020-10-21 23:00:04 UTC 5 hours ago
cli: update revisions to use releases API (#3329)

Author: Sergio Schvezov
Author Date: 2020-10-21 23:00:04 UTC

cli: update revisions to use releases API (#3329)

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

bp-apt-arch 2020-10-20 01:30:11 UTC 2020-10-20
Merge branch 'master' into bp-apt-arch

Author: Sergio Schvezov
Author Date: 2020-10-20 01:30:11 UTC

Merge branch 'master' into bp-apt-arch

command-not-found 2020-10-20 01:29:36 UTC 2020-10-20
Merge branch 'master' into command-not-found

Author: Sergio Schvezov
Author Date: 2020-10-20 01:29:36 UTC

Merge branch 'master' into command-not-found

python-v2-fixups 2020-10-19 12:21:18 UTC 2020-10-19
match beginnging/end of line

Author: Chris Patterson
Author Date: 2020-10-19 12:21:18 UTC

match beginnging/end of line

bash-core20 2020-10-14 23:58:46 UTC 2020-10-14
plugin handler: use bash with additional error checking for core20 scripts

Author: Chris Patterson
Author Date: 2020-10-14 20:30:00 UTC

plugin handler: use bash with additional error checking for core20 scripts

Bash allows us to `set -o pipefail` to catch pipe failures, e.g.
`fail | true` that dash will ignore.

In addition to switching to bash:

- Set '-o pipefail' to catch pipe errors.

- Set '-u' to catch unbound variable errors.

- Set '-x' to improve visibility of scriptlets.

To address the subsequent breakage:

- Only apply additional shell flags after the environmnet.
  Otherwise user build-environment may be unbound when using
  variables not applicable to the step (e.g. SNAPCRAFT_PART_INSTALL).

- Update v2 catkin/colcon to drop -u flag as there are plenty
  of unbound variables present in their scripts.

- Only apply these changes to core20, keeping legacy behavior
  the same for core/core18.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

set-x 2020-10-14 19:49:34 UTC 2020-10-14
plugin handler: set -x for scriptlets

Author: Chris Patterson
Author Date: 2020-10-14 19:43:53 UTC

plugin handler: set -x for scriptlets

Improve visibility for scriptlets, much like the behavior
for core20 plugins. It's a fairly common pattern for users
to add 'set -x' in their blocks and this will just enable
it by default.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

bp-lxdc 2020-10-01 13:41:18 UTC 2020-10-01
build providers: remote lxd

Author: Chris Patterson
Author Date: 2020-09-18 14:42:33 UTC

build providers: remote lxd

bp-unified-automount 2020-09-18 15:13:39 UTC 2020-09-18
build providers: make mount_project() interface private

Author: Chris Patterson
Author Date: 2020-09-18 14:42:33 UTC

build providers: make mount_project() interface private

It is as an implementation detail specific to the provider, even
though LXD and Multipass currently share the same logic. Remove
call from the CLI and automatically mount project when create()
occurs for LXD and Multipass.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

bp-unified-setup 2020-09-17 20:15:23 UTC 2020-09-17
build providers: unified provider refactoring for provider setup

Author: Chris Patterson
Author Date: 2020-09-17 19:40:24 UTC

build providers: unified provider refactoring for provider setup

Refactoring for unified approach to checking if a provider is ready, and
performing installation.

- Adds 'is_provider_ready()' interface, replacing 'ensure_provider()'.

- Makes 'setup_provider()' responsible for all user interaction to install
and/or configure the provider, and its depdenencies. Adds 'interactive'
parameter to allow for non-interactive installs, though not currently utilized.

- Refactored LXD checks into their own methods, adding a compatibility check to
check the LXD version is 4.0+, and removing the snap install check in favor of
just ensuring the hardcoded /snap/bin/lx[cd] paths are present.

- Moves setup code out of MultipassCommand into the Multipass provider.

- Update lifecycle CLI to utilize new interfaces. When tty is not connected,
and setup is required, exit with error that that build provider is not
installed or configured.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

legacy 2020-09-15 01:21:14 UTC 2020-09-15
v1 plugins: lock godep's dependencies (#3286)

Author: Chris Patterson
Author Date: 2020-09-15 01:21:14 UTC

v1 plugins: lock godep's dependencies (#3286)

godeps hasn't been updated in quite some time, but it has
dependencies that need to be locked [1]. Specifically, go-toml
has been updated recently to require newer string interfaces,
requiring go 1.10+, breaking godeps projects on older go
versions.

Since godeps is used for dependency tracking (prior to go
modules), we lock in the dependencies ourselves by checking
out the correct revisions after downloading via go-get.

https://github.com/rogpeppe/godeps/blob/master/dependencies.tsv

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

colcon-strip-env 2020-08-26 02:16:21 UTC 2020-08-26
colcon v2 plugin: don't strip env for stage-runtime-dependencies

Author: Chris Patterson
Author Date: 2020-08-25 14:58:31 UTC

colcon v2 plugin: don't strip env for stage-runtime-dependencies

HTTP proxy settings are being lost.

- Remove the `-i` argument to `env`, there are no longer variables
  that must be filtered, allow all of the build-time environment
  variables through. This will include http(s)_proxy once the
  run scripts include it (shipped separately).

- Remove parameters to `stage-runtime-dependencies` which can just
  be picked up from the environment now, after removing `-i` from
  `env`.

- Remove PATH from env list as it no longer needs to be passed
  through explicitly, it is in the run script.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

spec-pr-typo 2020-08-14 11:31:55 UTC 2020-08-14
specifications: fix typo in package-repositories

Author: Chris Patterson
Author Date: 2020-08-14 11:31:55 UTC

specifications: fix typo in package-repositories

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

fix-ld-regex 2020-08-13 16:02:48 UTC 2020-08-13
spread tests: fix classic patchelf linker regex to match all arches

Author: Chris Patterson
Author Date: 2020-08-13 15:59:02 UTC

spread tests: fix classic patchelf linker regex to match all arches

ppc64el and others may not follow the `ld-linux` convention, e.g.:
/snap/core18/current/lib64/ld64.so.2

Fix by broadening the match to ld.*.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

no-report-tool-missing 2020-07-20 15:07:42 UTC 2020-07-20
sentry: don't report tool missing errors

Author: Chris Patterson
Author Date: 2020-07-20 15:05:39 UTC

sentry: don't report tool missing errors

Spread tests should capture any missing tools from the snap,
should we make that mistake. If the host is missing the tool,
do not offer to report it to sentry.

Fixes SNAPCRAFT-1V7

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

openvino 2020-06-26 02:07:12 UTC 2020-06-26
edge -> stable build snap

Author: Chris Patterson
Author Date: 2020-06-26 02:07:12 UTC

edge -> stable build snap

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

fix-patchelf-mangling 2020-05-11 11:40:47 UTC 2020-05-11
get section by name and check for SHT_NOBITS

Author: Chris Patterson
Author Date: 2020-05-11 11:40:47 UTC

get section by name and check for SHT_NOBITS

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

specifications 2020-03-04 15:22:14 UTC 2020-03-04
initial commit

Author: Sergio Schvezov
Author Date: 2020-03-04 15:22:14 UTC

initial commit

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

rb-snapcraft-channel 2020-02-12 17:35:31 UTC 2020-02-12
remote-build: introduce --launchpad-snapcraft-channel option

Author: Chris Patterson
Author Date: 2020-02-12 17:32:33 UTC

remote-build: introduce --launchpad-snapcraft-channel option

It may be useful to configure Launchpad to use a specific
snapcraft channel. This commit changes the default from "edge"
to "stable", and allows the user to configure it.

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

split-debug 2020-02-05 15:59:54 UTC 2020-02-05
plugin handler: split debug information if --split-debug passed

Author: Chris Patterson
Author Date: 2020-01-10 21:51:42 UTC

plugin handler: split debug information if --split-debug passed

EXPERIMENTAL option to split debug information. Splits debug
information during PRIME step.

Stripped symbols are written to ./debug directory. Note that this
may cause an issue for projects being build in destructive mode that
already have a directory "debug" in the project tree.

Based off of James Henstridge's work available at:
https://github.com/snapcore/snapcraft/pull/2239

Signed-off-by: Chris Patterson <chris.patterson@canonical.com>

fix-elf-regression 2020-02-04 21:01:43 UTC 2020-02-04
use a generator for any

Author: Sergio Schvezov
Author Date: 2020-02-04 21:01:43 UTC

use a generator for any

release/3.9 2020-01-26 06:36:41 UTC 2020-01-26
meta: always generate snapcraft-runner to workaround classic (#2889) (#2891)

Author: Sergio Schvezov
Author Date: 2020-01-26 06:36:41 UTC

meta: always generate snapcraft-runner to workaround classic (#2889) (#2891)

Snapcraft previously generated wrappers for most commands. Once
snapcraft became more conserative about generating unnecessary wrappers,
issues began to surface with regard to PATH being set incorrectly
for classic snap apps that did not use shell.

To work around the issue, this commit adds an empty snapcraft-runner to
the command-chain for all apps, where they typically would have none.
Once this issue is resolved in snapd, we can probably remove this
workaround.

Add unit tests for snapcraft-runner generation

Add some additional parameters to the SnapcraftYaml fixture
to make it more configurable.

LP: #1860369

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Co-authored-by: Chris Patterson <cjp256@gmail.com>

122 of 22 results

Other repositories

Name Last Modified
lp:snapcraft 2 hours ago
lp:~kyrofa/snapcraft 2019-02-01
lp:~facundo/snapcraft 2017-10-13
lp:~vila/snapcraft/+git/mirror 2016-05-23
lp:~blr/snapcraft/+git/mirror 2016-04-13
15 of 5 results
You can't create new repositories for Snapcraft.