Application Menu Indicator

Code review comment for lp:~ted/indicator-appmenu/lp934429

Revision history for this message

Lars Karlitski (larsu) wrote on 2012-02-21:

I'm unsure that this fixes the bug. The stacktrace shows g_variant_build_add_value crashing because receiving a NULL value, which could be

  app,
  db,
  dbus_address,
  dbus_path or
  dbus_id'

This patch only does NULL checks for 'display', 'app_icon' and 'item_icon'.

Am I missing something? (Disclaimer: I haven't reproduced the bug or tested this patch)

Btw, this should be fixed in glib, so that passing a NULL value will at least throw a fatal error.

review: Needs Information