Merge lp:~ted/indicator-appmenu/lp934429 into lp:indicator-appmenu/0.4
Proposed by
Ted Gould
Status: | Merged |
---|---|
Merged at revision: | 165 |
Proposed branch: | lp:~ted/indicator-appmenu/lp934429 |
Merge into: | lp:indicator-appmenu/0.4 |
Diff against target: |
16 lines (+6/-0) 1 file modified
src/hud-search.c (+6/-0) |
To merge this branch: | bzr merge lp:~ted/indicator-appmenu/lp934429 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lars Karlitski (community) | Approve | ||
Review via email: mp+93886@code.launchpad.net |
Description of the change
Ensuring we always have values for GVariant
To post a comment you must log in.
I'm unsure that this fixes the bug. The stacktrace shows g_variant_ build_add_ value crashing because receiving a NULL value, which could be
app,
db,
dbus_address,
dbus_path or
dbus_id'
This patch only does NULL checks for 'display', 'app_icon' and 'item_icon'.
Am I missing something? (Disclaimer: I haven't reproduced the bug or tested this patch)
Btw, this should be fixed in glib, so that passing a NULL value will at least throw a fatal error.