Code review comment for ~sylvain-pineau/plainbox-provider-tpm2:clevis-jobs

Revision history for this message
Jonathan Cave (jocave) wrote :

Thanks for the effort going through the specs on this one. Looks really clean and gives us something much more like a realistic use-case.

Good to land as it. Some small improvements might be more verbosity in the tests, which might seem like overkill given they are one-liners, but I think it's reassuring to seem what might is going on.

review: Approve

« Back to merge proposal