Checkbox Provider - Base

Code review comment for ~sylvain-pineau/plainbox-provider-checkbox:beacon-notif-test

  1. Git
  2. lp:~sylvain-pineau/plainbox-provider-checkbox
  3. beacon-notif-test
  4. Merge into master
Revision history for this message
Maciej Kisielewski (kissiel) wrote :

Props for battling another BT story!
Code looks great, +1.
Nitpick: I found one unnecessary condition (I think, see inline), and the `pattern` name bothers me for identifying the adapter.

review: Approve

« Back to merge proposal