Merge ~sylvain-pineau/plainbox-provider-checkbox:beacon-notif-test into plainbox-provider-checkbox:master
Proposed by
Sylvain Pineau
Status: | Merged |
---|---|
Approved by: | Sylvain Pineau |
Approved revision: | cfccea5375aca495e52235832ced4e8782712b14 |
Merged at revision: | 3671705c73281db9ef35400d27d7c9a7e167a376 |
Proposed branch: | ~sylvain-pineau/plainbox-provider-checkbox:beacon-notif-test |
Merge into: | plainbox-provider-checkbox:master |
Diff against target: |
275 lines (+261/-0) 2 files modified
bin/gatt-notify-test.py (+241/-0) units/bluetooth/jobs.pxu (+20/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sylvain Pineau (community) | Approve | ||
Devices Certification Bot | Needs Fixing | ||
Maciej Kisielewski | Approve | ||
Review via email: mp+348823@code.launchpad.net |
Description of the change
Generic GATT notification test to use with Bluetooth LE beacons.
Made generic by using three env settings:
- ADV_SVC_UUID: General/
the device is not connected
- SVC_UUID: GATT service to use to enable notifications.
- MSRMT_UUID: GATT characteristic from the SVC_UUID service to trigger
notifications.
Tested on Tillamook devices where it works when all planets are aligned.
To post a comment you must log in.
Props for battling another BT story!
Code looks great, +1.
Nitpick: I found one unnecessary condition (I think, see inline), and the `pattern` name bothers me for identifying the adapter.